Bug 43903 - ring_remove: ASSERT item->next != NULL && item->prev != NULL failed
Summary: ring_remove: ASSERT item->next != NULL && item->prev != NULL failed
Status: RESOLVED FIXED
Alias: None
Product: Spice
Classification: Unclassified
Component: server (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Spice Bug List
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-17 00:47 UTC by Hans de Goede
Modified: 2011-12-18 02:57 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Patch fixing this bug (1.97 KB, patch)
2011-12-18 02:25 UTC, Hans de Goede
Details | Splinter Review

Description Hans de Goede 2011-12-17 00:47:27 UTC
Hi,

nicolas prochazka <prochazka.nicolas@gmail.com> hit this when testing the usbredir support, and reported it to me in a private mail.

I hope the backtrace has enough info to figure out what is going on, if not feel free to close this.

reds_handle_main_link: 
reds_disconnect: 
reds_client_disconnect: 
red_client_destroy: destroy client with #channels 5
red_channel_client_disconnect: 0x7f06154b83a0 (channel 0x7f0614c1db50 type 9 id 0)
ring_remove: ASSERT item->next != NULL && item->prev != NULL failed
/usr/lib/libspice-server.so.1(+0xad84c)[0x7f06107ac84c]
/usr/lib/libspice-server.so.1(+0x17871)[0x7f0610716871]
/usr/lib/libspice-server.so.1(+0x17a62)[0x7f0610716a62]
/usr/lib/libspice-server.so.1(+0x34f31)[0x7f0610733f31]
/usr/lib/libspice-server.so.1(+0x3505a)[0x7f061073405a]
/usr/lib/libspice-server.so.1(+0x37394)[0x7f0610736394]
/usr/local/bin/qemu(+0xb8367)[0x7f061299c367]
/usr/local/bin/qemu(+0x125d1f)[0x7f0612a09d1f]
/usr/local/bin/qemu(main+0xe24)[0x7f0612a03224]
/lib/libc.so.6(__libc_start_main+0xec)[0x7f060fd13cbc]
/usr/local/bin/qemu(+0x6a359)[0x7f061294e359]

This happened on client disconnect, while testing usbredir.

Regards,

Hans
Comment 1 Hans de Goede 2011-12-18 02:24:08 UTC
Good news I (unintentionally, but that does not matter) have managed to come up with a reproducer and debug this. I'll attach a patch fixing this. I'll push that patch to upstream git master as soon as it gets a favorable review.
Comment 2 Hans de Goede 2011-12-18 02:25:16 UTC
Created attachment 54533 [details] [review]
Patch fixing this bug
Comment 3 Hans de Goede 2011-12-18 02:57:35 UTC
Patch is in git master now, closing.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.