Making all in vapi make[2]: Entering directory `/home/src/pkgs/spice-gtk/BUILD/spice-gtk-0.7.150-e507/vapi' make[2]: *** No rule to make target `spice-client-glib-2.0.deps', needed by `all-am'. Stop. make[2]: Leaving directory `/home/src/pkgs/spice-gtk/BUILD/spice-gtk-0.7.150-e507/vapi' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/src/pkgs/spice-gtk/BUILD/spice-gtk-0.7.150-e507' make: *** [all] Error 2 error: Bad exit status from /home/src/pkgs/spice-gtk/BUILDROOT/rpm-tmp.wZZVB3 (%build)
What is the full build log? Are you only running configure, or are you rerunning autogen.sh/autoreconf?
I am working on a fix
We/Mageia indeed run the following: autoreconf -vfi intltoolize --force %configure2_5x \ --with-gtk=%{gtkapi} \ --disable-static \ %if %{build_vala} --enable-vala %else --disable-vala %endif no idea why we do that.. think it is because of some old patch.
I know you're working on a fix, but have submitted spice-gtk to http://pkgsubmit.mageia.org/ anyway so you can see the full build. I've removed the autoreconf + intltoolize and enabled vala.
Created attachment 54645 [details] build log
patch from Mageia: http://svnweb.mageia.org/packages/cauldron/spice-gtk/current/SOURCES/spice-gtk-0.7.150-e507-add-missing-spice-client-glib-2.0.deps.patch?revision=185488&view=co&pathrev=185488
Created attachment 54660 [details] [review] build: ship vala files & fix make distcheck Disable usbredir, since it wants to install file in /. Disable vala for distcheck for 2 reasons: not needed after dist and binding build issue. Ship with spice-gtk-3.0 vala bindings
Comment on attachment 54660 [details] [review] build: ship vala files & fix make distcheck Review of attachment 54660 [details] [review]: ----------------------------------------------------------------- ::: vapi/Makefile.am @@ +29,4 @@ > $(AM_V_GEN)$(VAPIGEN) \ > --vapidir=$(builddir) \ > --girdir=$(top_builddir)/gtk \ > + --pkg gio-2.0 \ that line isn't needed, I removed it
-VALA_REQUIRED=0.11.7 +VALA_REQUIRED=0.15 0.14 please :)
@@ -16,6 +13,13 @@ vapi_DATA = \ $(BUILT_VAPI) $(NULL) A \ is missing after $(BUILT_VAPI), can you slip it in this patch?
Created attachment 54673 [details] [review] Some more fixes on top of it, but not enough :-/ The way things are currently done won't work out to generate a tarball. We build either -gtk-3.0.vapi or -gtk-2.0.vapi, we never build both. This means only one of these will get in the tarball, thus if the tarball was made with --with-gtk=3.0, a build from the tarball with --with-gtk=2.0 won't work. The patch I've attached addresses this for .deps file, not sure how .vapi files should be handled.
Created attachment 54678 [details] [review] Fixes the vapi issues too After discussing this issue on IRC, I came up with this patch which allows me to successfully build spice-gtk with --with-gtk=2.0 and --with-gtk=3.0
Created attachment 54687 [details] [review] Better fix (imo)
I can raise the vala requirement in this patch as well if you think it must be done.
(In reply to comment #13) > Created attachment 54687 [details] [review] [review] > Better fix (imo) Ok, if make distcheck passes with it, go for it, add a reference to the bug in the commit msg. thanks
Make distcheck passes (though I have to run make once before make distchecking in a directory I just cleaned with git clean -dfx, but this may be the expected behaviour)
I've pushed this as 3f9872b695ac479a6efd840c39ab45516478bb9c , now we should respin another release
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.