Bug 44000 - Vala build error for 0.7.150
Summary: Vala build error for 0.7.150
Alias: None
Product: Spice
Classification: Unclassified
Component: spice-gtk (show other bugs)
Version: unspecified
Hardware: Other All
: medium blocker
Assignee: Spice Bug List
QA Contact:
Depends on:
Reported: 2011-12-21 01:00 UTC by Olav Vitters
Modified: 2011-12-22 07:20 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

build log (380.83 KB, text/plain)
2011-12-21 07:42 UTC, Olav Vitters
build: ship vala files & fix make distcheck (3.10 KB, patch)
2011-12-21 17:17 UTC, Marc-Andre Lureau
Details | Splinter Review
Some more fixes on top of it, but not enough :-/ (1.93 KB, patch)
2011-12-22 02:00 UTC, Christophe Fergeau
Details | Splinter Review
Fixes the vapi issues too (24.42 KB, patch)
2011-12-22 03:04 UTC, Christophe Fergeau
Details | Splinter Review
Better fix (imo) (3.88 KB, patch)
2011-12-22 05:25 UTC, Christophe Fergeau
Details | Splinter Review

Description Olav Vitters 2011-12-21 01:00:37 UTC
Making all in vapi
make[2]: Entering directory `/home/src/pkgs/spice-gtk/BUILD/spice-gtk-0.7.150-e507/vapi'
make[2]: *** No rule to make target `spice-client-glib-2.0.deps', needed by `all-am'.  Stop.
make[2]: Leaving directory `/home/src/pkgs/spice-gtk/BUILD/spice-gtk-0.7.150-e507/vapi'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/src/pkgs/spice-gtk/BUILD/spice-gtk-0.7.150-e507'
make: *** [all] Error 2
error: Bad exit status from /home/src/pkgs/spice-gtk/BUILDROOT/rpm-tmp.wZZVB3 (%build)
Comment 1 Christophe Fergeau 2011-12-21 02:46:45 UTC
What is the full build log? Are you only running configure, or are you rerunning autogen.sh/autoreconf?
Comment 2 Marc-Andre Lureau 2011-12-21 03:12:47 UTC
I am working on a fix
Comment 3 Olav Vitters 2011-12-21 07:11:47 UTC
We/Mageia indeed run the following:

autoreconf -vfi
intltoolize --force
%configure2_5x \
	--with-gtk=%{gtkapi} \
	--disable-static \
%if %{build_vala}

no idea why we do that.. think it is because of some old patch.
Comment 4 Olav Vitters 2011-12-21 07:15:25 UTC
I know you're working on a fix, but have submitted spice-gtk to http://pkgsubmit.mageia.org/ anyway so you can see the full build. I've removed the autoreconf + intltoolize and enabled vala.
Comment 5 Olav Vitters 2011-12-21 07:42:40 UTC
Created attachment 54645 [details]
build log
Comment 7 Marc-Andre Lureau 2011-12-21 17:17:26 UTC
Created attachment 54660 [details] [review]
build: ship vala files & fix make distcheck

Disable usbredir, since it wants to install file in /.

Disable vala for distcheck for 2 reasons: not needed after dist and
binding build issue.

Ship with spice-gtk-3.0 vala bindings
Comment 8 Marc-Andre Lureau 2011-12-21 17:22:21 UTC
Comment on attachment 54660 [details] [review]
build: ship vala files & fix make distcheck

Review of attachment 54660 [details] [review]:

::: vapi/Makefile.am
@@ +29,4 @@
>  	$(AM_V_GEN)$(VAPIGEN)						\
>  		--vapidir=$(builddir)					\
>  		--girdir=$(top_builddir)/gtk				\
> +		--pkg gio-2.0                                           \

that line isn't needed, I removed it
Comment 9 Christophe Fergeau 2011-12-22 00:53:21 UTC

0.14 please :)
Comment 10 Christophe Fergeau 2011-12-22 01:38:42 UTC
@@ -16,6 +13,13 @@ vapi_DATA =						\

A \ is missing after $(BUILT_VAPI), can you slip it in this patch?
Comment 11 Christophe Fergeau 2011-12-22 02:00:01 UTC
Created attachment 54673 [details] [review]
Some more fixes on top of it, but not enough :-/

The way things are currently done won't work out to generate a tarball. We build either -gtk-3.0.vapi or -gtk-2.0.vapi, we never build both. This means only one of these will get in the tarball, thus if the tarball was made with --with-gtk=3.0, a build from the tarball with --with-gtk=2.0 won't work. The patch I've attached addresses this for .deps file, not sure how .vapi files should be handled.
Comment 12 Christophe Fergeau 2011-12-22 03:04:17 UTC
Created attachment 54678 [details] [review]
Fixes the vapi issues too

After discussing this issue on IRC, I came up with this patch which allows me to successfully build spice-gtk with --with-gtk=2.0 and --with-gtk=3.0
Comment 13 Christophe Fergeau 2011-12-22 05:25:32 UTC
Created attachment 54687 [details] [review]
Better fix (imo)
Comment 14 Christophe Fergeau 2011-12-22 05:26:32 UTC
I can raise the vala requirement in this patch as well if you think it must be done.
Comment 15 Marc-Andre Lureau 2011-12-22 05:42:35 UTC
(In reply to comment #13)
> Created attachment 54687 [details] [review] [review]
> Better fix (imo)

Ok, if make distcheck passes with it, go for it, add a reference to the bug in the commit msg.

Comment 16 Christophe Fergeau 2011-12-22 06:14:03 UTC
Make distcheck passes (though I have to run make once before make distchecking in a directory I just cleaned with git clean -dfx, but this may be the expected behaviour)
Comment 17 Christophe Fergeau 2011-12-22 07:20:00 UTC
I've pushed this as 3f9872b695ac479a6efd840c39ab45516478bb9c , now we should respin another release

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.