Bug 4402 - Selection crash
Summary: Selection crash
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: high critical
Assignee: Kristian Høgsberg
QA Contact:
URL:
Whiteboard:
Keywords:
: 4326 4386 4929 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-09-08 19:16 UTC by Johan Dahlin
Modified: 2005-12-03 13:57 UTC (History)
6 users (show)

See Also:
i915 platform:
i915 features:


Attachments
proposed fix (633 bytes, patch)
2005-09-08 19:17 UTC, Johan Dahlin
Details | Splinter Review
Proposed patch (1.13 KB, patch)
2005-11-17 09:51 UTC, Nickolay V. Shmyrev
Details | Splinter Review
Updated patch (4.19 KB, patch)
2005-11-18 02:09 UTC, Nickolay V. Shmyrev
Details | Splinter Review

Description Johan Dahlin 2005-09-08 19:16:19 UTC
If you select some text in evince and then tries to select something again it
crashes in a reproducible manner.
Comment 1 Johan Dahlin 2005-09-08 19:17:17 UTC
Created attachment 3205 [details] [review]
proposed fix
Comment 2 Johan Dahlin 2005-09-08 19:21:48 UTC
For a stack trace, see:
http://bugzilla.gnome.org/show_bug.cgi?id=315552
Comment 3 Nickolay V. Shmyrev 2005-10-24 14:22:34 UTC
krh, this bug has more than ten dups in evince bugzilla. Any chance to see patch
applied?
Comment 4 Nickolay V. Shmyrev 2005-10-30 22:10:47 UTC
I've discussed that bug with krh on irc and he was disappointed that p == NULL
appears in the list. It should _not_ be so. Really, why it doesn't happens on
splash and only on cairo backend? So this patch doesn't solve the reason of
trouble. I think we should found why NULL is appeared on the list.
Comment 5 Nickolay V. Shmyrev 2005-11-17 09:51:37 UTC
Created attachment 3819 [details] [review]
Proposed patch

This patch should fix the problem, the real reason was that begin >= end
invariant was not holded.
Comment 6 Nickolay V. Shmyrev 2005-11-18 02:09:24 UTC
Created attachment 3830 [details] [review]
Updated patch

The previous patch doesn't solve all cases in selection crashes. The updated
patch is intended to do that. Besides it fixes build of current CVS with cairo
and several splash color problems.
Comment 7 Nickolay V. Shmyrev 2005-11-20 01:46:28 UTC
*** Bug 4386 has been marked as a duplicate of this bug. ***
Comment 8 P.M. 2005-11-20 12:01:42 UTC
Would you like testing on this? I'm one of the people that reported this bug
against Evince. If there are particular things to try that should exercise this,
I'm willing to give them a shot.
Comment 9 Nickolay V. Shmyrev 2005-11-20 23:03:11 UTC
P.M. Of course testing is needed
Comment 10 Nickolay V. Shmyrev 2005-11-24 19:44:10 UTC
krh: ping, evince bug already has more than 20 dups
Comment 11 Kristian Høgsberg 2005-12-04 07:41:17 UTC
*** Bug 4929 has been marked as a duplicate of this bug. ***
Comment 12 Kristian Høgsberg 2005-12-04 08:46:16 UTC
*** Bug 4326 has been marked as a duplicate of this bug. ***
Comment 13 Kristian Høgsberg 2005-12-04 08:57:10 UTC
Nickolay, thanks, I've committed you patch to CVS HEAD.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.