Bug 44028 - telepathy-glib fails to cross compile with mingw32
Summary: telepathy-glib fails to cross compile with mingw32
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other Windows (All)
: medium normal
Assignee: Siraj Razick
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.com/git/user/si...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-12-21 12:08 UTC by Siraj Razick
Modified: 2011-12-22 23:39 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Siraj Razick 2011-12-21 12:08:25 UTC
telepathy-glib fails to cross compile with mingw32.
Comment 1 Siraj Razick 2011-12-21 12:16:33 UTC
patch with build fixes
Comment 2 Stef Walter 2011-12-22 04:13:21 UTC
+#ifdef G_OS_WIN32
+      case TP_SOCKET_ADDRESS_TYPE_UNIX:
+      case TP_SOCKET_ADDRESS_TYPE_ABSTRACT_UNIX:
+        break;
+#endif

Shouldn't this section be an #else of the previous clause? Or at least be "#ifndef HAVE_GIO_UNIX"
Comment 3 Jonny Lamb 2011-12-22 05:49:49 UTC
What Stef said. The rest looks fine, or can those includes be removed completely?
Comment 4 Siraj Razick 2011-12-22 10:37:41 UTC
(In reply to comment #3)
> What Stef said. The rest looks fine, or can those includes be removed
> completely?

Yep, I removed the headers and it compiles fine on linux and also in mingw..
the patch is now updated with all the changes proposed.
Comment 5 Jonny Lamb 2011-12-22 15:11:35 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > What Stef said. The rest looks fine, or can those includes be removed
> > completely?
> 
> Yep, I removed the headers and it compiles fine on linux and also in mingw..
> the patch is now updated with all the changes proposed.

Looks good.

Do you have permissions to push or shall I do it for you?
Comment 6 Siraj Razick 2011-12-22 18:05:19 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > What Stef said. The rest looks fine, or can those includes be removed
> > > completely?
> > 
> > Yep, I removed the headers and it compiles fine on linux and also in mingw..
> > the patch is now updated with all the changes proposed.
> 
> Looks good.
> 
> Do you have permissions to push or shall I do it for you?

Hi, nop.. I don't have permission, it would  be cool if you can push it :)
Comment 7 Jonny Lamb 2011-12-22 23:39:29 UTC
Merged, thanks!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.