Bug 4405 - Incorrect version check for pycairo
Summary: Incorrect version check for pycairo
Status: RESOLVED FIXED
Alias: None
Product: pycairo
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Steve Chaplin
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-09 09:38 UTC by Wouter Bolsterlee
Modified: 2005-09-10 00:57 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Proposed patch which fixes the logic (412 bytes, patch)
2005-09-09 09:38 UTC, Wouter Bolsterlee 		Details | Splinter Review
View All

Description Wouter Bolsterlee 2005-09-09 09:38:15 UTC 
pycairo's configure script refuses to build cairo.gtk, even if pygtk is
available. It seems that the check done contains reversed logic.
Comment 1 Wouter Bolsterlee 2005-09-09 09:38:55 UTC 
Created attachment 3211 [details] [review]
Proposed patch which fixes the logic
Comment 2 Wouter Bolsterlee 2005-09-09 09:39:49 UTC 
Or remove the third line at all ;)
Comment 3 Wouter Bolsterlee 2005-09-09 09:41:09 UTC 
In that case, also bump the required pygtk version to 2.7
Comment 4 Steve Chaplin 2005-09-10 17:57:32 UTC 
The cairo.gtk module was written as a temporary solution to allow pygtk to use
pycairo. Now pygtk >= 2.7.0 supports pycairo, so cairo.gtk is no longer needed,
and will eventually be deprecated and deleted. 
examples/gtk/text.py shows how to use pycairo with pygtk.

I've updated the INSTALL file to say:
If pygtk >= 2.7.0 is detected then cairo.gtk is not built since pycairo
is now supported directly by pygtk.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.