Bug 4413 - CairoOutputDev.h includes wrong path for cairo-ft.h [build breaks]
Summary: CairoOutputDev.h includes wrong path for cairo-ft.h [build breaks]
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: high blocker
Assignee: Kristian Høgsberg
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-10 08:16 UTC by Christian Lohmaier
Modified: 2005-12-03 13:47 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
minimalistic patch (292 bytes, patch)
2005-09-10 08:32 UTC, Christian Lohmaier
Details | Splinter Review

Description Christian Lohmaier 2005-09-10 08:16:22 UTC
CairoOutputDev.h includes cairo/cairo-ft.h, but "pkg-config --cflags cairo"
already returns %{_includedir}/cairo. To reproduce: Install cairo into a prefix
that is not part of the default paths that gcc uses (I used /opt/gnome2).

$ pkg-config --cflags cairo
-I/opt/gnome2/include/cairo
$ rpm -ql cairo |grep cairo-ft.h
/opt/gnome2/include/cairo/cairo-ft.h

Modifying CairoOutputDev.h to only include "cairo-ft.h" allows the build to succeed.

Full error message:
 g++ -DHAVE_CONFIG_H -I. -I. -I.. -I. -I.. -I/opt/gnome2/include/cairo
-I/usr/include/freetype2 -DDATADIR=\"/opt/gnome2/share\" -Wall -Wno-unused
-march=athlon-xp -m3dnow -msse -mfpmath=sse -mmmx -Os -pipe -fforce-addr
-fomit-frame-pointer -frerun-cse-after-loop -frerun-loop-opt -falign-functions=4
-maccumulate-outgoing-args -fpic -MT CairoOutputDev.lo -MD -MP -MF
.deps/CairoOutputDev.Tpo -c CairoOutputDev.cc  -fPIC -DPIC -o .libs/CairoOutputDev.o
In file included from CairoOutputDev.cc:31:
CairoOutputDev.h:18:28: cairo/cairo-ft.h: No such file or directory
In file included from CairoOutputDev.cc:31:
CairoOutputDev.h:146: 'FT_Library' is used as a type, but is not defined as a type.
CairoOutputDev.cc: In constructor `CairoOutputDev::CairoOutputDev()':
CairoOutputDev.cc:54: `ft_lib' undeclared (first use this function)
CairoOutputDev.cc:54: (Each undeclared identifier is reported only once for each
function it appears in.)
Comment 1 Christian Lohmaier 2005-09-10 08:32:44 UTC
Created attachment 3221 [details] [review]
minimalistic patch

patch is needed to make poppler compile with cairo 1.0.0 when cairo is not
installed to /usr
Comment 2 Nickolay V. Shmyrev 2005-11-20 23:02:12 UTC
also patch to 4402 has the same fix
Comment 3 Kristian Høgsberg 2005-12-04 08:47:07 UTC
Fixed in CVS HEAD.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.