Bug 4435 - bin/installmesa script is bsd-incompatible
Summary: bin/installmesa script is bsd-incompatible
Status: RESOLVED INVALID
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: Other FreeBSD
: high normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-12 17:42 UTC by Diego Elio Pettenò
Modified: 2009-05-31 17:34 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
mesa-6.3.2-freebsdinst.patch (1.23 KB, patch)
2005-09-12 17:42 UTC, Diego Elio Pettenò
Details | Splinter Review

Description Diego Elio Pettenò 2005-09-12 17:42:12 UTC
The attached patch makes it work on FreeBSD userland. 
Basically -d option to cp is a GNU extension and so doesn't work on FreeBSD at 
all, while [ ] operands must be escaped if the shell is not bash. 
 
HTH, 
Diego
Comment 1 Diego Elio Pettenò 2005-09-12 17:42:25 UTC
Created attachment 3245 [details] [review]
mesa-6.3.2-freebsdinst.patch
Comment 2 Eric Anholt 2005-09-12 22:21:14 UTC
I would consider using that script a mistake on BSDs, given that it would
install badly-named libraries.  We really need a proper build system
(unfortunately, that tends to mean autotools).
Comment 3 Brian Paul 2005-09-13 06:38:55 UTC
I checked in the patch but I added a test of `uname`="FreeBSD" to determine
which copy flags to use.

We're not going to use autotools.

What exactly are the "badly-named libraries"?
Comment 4 Eric Anholt 2005-09-13 10:52:27 UTC
libGL.so.1.2.  We don't do minor numbers, since they're meaningless for us.  So
it's at least nonstandard, and possibly broken.  And the script doesn't seem to
cover the DRI libraries or demo apps (if they've been built), either.

When packaging Mesa, I have to make custom config files, and then write my own
install script. Of the 20 or so packages I maintain for FreeBSD, Mesa and
chromium are the only ones I do custom installs for.
Comment 5 Brian Paul 2005-09-13 11:12:17 UTC
Eric, feel free to edit bin/mklib to remove the minor version number from the
libraries for FreeBSD.

I can fix the install script to install the DRI drivers, but it sounds like
something else is needed for FreeBSD.  Again, feel free to fix the install
script or add an additional one for FreeBSD.

As for installing the demo programs, I'm not sure that's needed.  I guess I
could go either way.
Comment 6 Hanno Böck 2006-08-28 08:02:55 UTC
Hi, from what I know installmesa isn't used any more (brianp, maybe you'd 
better remove it if this is the case), I'm not familiar with freebsd, but maybe 
someone should have a look if this bug is still valid.
Comment 7 Brian Paul 2006-08-28 08:12:53 UTC
I'll remove installmesa from the tarballs.
I don't have a FreeBSD system to test on.
Comment 8 Dan Nicholson 2009-05-31 10:33:59 UTC
Nothing uses installmesa anymore. Brian, can we remove it from the repo, too?
Comment 9 Brian Paul 2009-05-31 17:34:41 UTC
Sure, go ahead and remove it.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.