Created attachment 55011 [details] [review]
Patch to fix the problem
Both screen and rxvt-unicode expect to receive their command lines pre-parsed for quoting and, if given a single string like "echo foo", will fail because the string as a whole cannot be exec()ed.
Furthermore, screen has its own, incompatible meaning for -e.
I've attached an initial patch which resolves these issues but, because I'm unfamiliar with dash, I've also included a TODO: comment explaining the main remaining issue.
The patch may depend on the one-character correction in my patch to bug 44356. I'm relatively new to submitting patches rather than GitHub pull requests.
Oh, I forgot to mention. As with all the other patches I've submitted in the last few days, this is to fix the version at current git HEAD. (b961235b197647d6649ef3d48d7cc2cecafe3d47)
Thanks, given we don't release or support this piece really, meh, ok. :)
I figured it was better to fix up an existing bit of code and contribute back rather than re-inventing it.
Maybe someday I won't need to bundle a copy of xdg-terminal with my project. (What's holding it up anyway? Lack of a maintainer?)
I'm not 100% of the history, I only started directly contributing over the past few years, but... I think it was mostly a matter of polish and lack of maintainer, yeah.
If it's just polish and maintainership it needs, I could probably reorganize my schedule. What's the appropriate place to discuss that sort of thing? Is there an NNTP-accessible mailing list? (eg. via GMane)
(My Thunderbird-GMail IMAP integration is broken enough as it is without throwing in a firehose of irrelevant discussion threads.)
Is it me or the patch has been wrongly applied to terminal_kde instead of to terminal_generic?
Good eye, (re) fixed in the right place this time. thanks!
on Jul 28, 2016 at 02:53:17.
(provided by the Example extension).