Bug 44358 - xdg-terminal doesn't handle common non-command TERM values like TERM=linux (Lubuntu)
Summary: xdg-terminal doesn't handle common non-command TERM values like TERM=linux (L...
Status: RESOLVED FIXED
Alias: None
Product: Portland
Classification: Unclassified
Component: xdg-utils (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Portland Bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-31 17:34 UTC by Stephan Sokolow
Modified: 2012-03-02 10:59 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Patch to fix the problem (659 bytes, patch)
2011-12-31 17:34 UTC, Stephan Sokolow 		Details | Splinter Review
View All

Description Stephan Sokolow 2011-12-31 17:34:13 UTC 
Created attachment 55012 [details] [review]
Patch to fix the problem

Under some common circumstances, (eg. Lubuntu 11.10 with the "Lubuntu" session and gmrun), the current git HEAD (b961235b197647d6649ef3d48d7cc2cecafe3d47) for xdg-terminal sees TERM=linux and DE=generic and doesn't attempt to fall back to xterm.

This could also conceivably happen with TERM=vt100 but a valid DISPLAY in some types of more esoteric network-transparent X11 setups.

I've attached a patch which extends the basic check for an empty TERM value to also test for "linux" and "vt100".

However, in the long term, the most proper solution would be to test whether the value of TERM is a valid command and use a fallback if that test fails.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.