Bug 44455 - generate run-with-tmp-session-bus.conf in a way that CMake can deal with
Summary: generate run-with-tmp-session-bus.conf in a way that CMake can deal with
Status: RESOLVED MOVED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: 1.5
Hardware: All All
: low enhancement
Assignee: D-Bus Maintainers
QA Contact: D-Bus Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-04 10:50 UTC by Simon McVittie
Modified: 2018-10-12 21:13 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Simon McVittie 2012-01-04 10:50:53 UTC 
I've reverted the commits 4f404b560378fdb92a041532ffcfc12b6f194bec and 5071f3e87aaf225e56ce1a684d8325431b499f92 from master ("made session service dirs customizable") because:

* they make the tests fail under Unix with Autotools (by far the most prominent way to build D-Bus) - I think I see what you were trying to do, but the variable assignment in Makefile.am isn't needed for that, and a use of AC_SUBST *is* needed

* they weren't reviewed, or (as far as I could see while catching up after Christmas) discussed

* they don't reference a bug report or explain the reasoning, so I can't see why these changes were made

I think I can see what the goal was - generating run-with-tmp-session-bus.conf from the build system, rather than from the shell script that runs the tests - and I agree that it's nice to use the same source file for session.conf and run-with-tmp-session-bus.conf, but please do not commit changes without at least one of testing or thorough review, and preferably both.
Comment 1 GitLab Migration User 2018-10-12 21:13:21 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/dbus/dbus/issues/62.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.