44480 – Build error with LLVM -DLLVM_APPEND_VC_REV=ON

Bug 44480 - Build error with LLVM -DLLVM_APPEND_VC_REV=ON

Summary: Build error with LLVM -DLLVM_APPEND_VC_REV=ON

Status:	RESOLVED FIXED

Alias:	None

Product:	Mesa
Classification:	Unclassified
Component:	Mesa core (show other bugs)
Version:	git
Hardware:	Other All

Importance:	medium normal
Assignee:	mesa-dev
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2012-01-04 22:13 UTC by ojab
Modified:	2012-01-05 22:46 UTC (History)
CC List:	0 users

See Also:
i915 platform:
i915 features:

Attachments
Strip LLVM svn rev from `llvm-config --version` output (500 bytes, application/octet-stream) 2012-01-04 22:13 UTC, ojab	Details
Use git format-patch (794 bytes, patch) 2012-01-05 02:21 UTC, ojab	Details \| Splinter Review
Show Obsolete (1) View All

Description ojab 2012-01-04 22:13:00 UTC

Created attachment 55154 [details]
Strip LLVM svn rev from `llvm-config --version` output

LLVM CMake build has an option to append svn rev to version (LLVM_APPEND_VC_REV), related ./autogen.sh output looks like something like:
llvm-version:    3.1svn-r147373

which lead us to -DHAVE_LLVM=0x0301svn-r147373 and
make[3]: Entering directory `/sources/mesa/src/gallium/auxiliary'
In file included from draw/draw_context.c:40:0:
draw/draw_vs.h:169:5: error: invalid suffix "svn" on integer constant
draw/draw_context.c:43:5: error: invalid suffix "svn" on integer constant

Possible patch in the attached file.

Comment 1 Vinson Lee 2012-01-05 00:22:49 UTC

Thanks. The patch id=55154 looks okay to me.
Reviewed-by: Vinson Lee <vlee@freedesktop.org>

ojab, can you please recreate the patch with git format-patch?

Comment 2 ojab 2012-01-05 02:21:11 UTC

Created attachment 55160 [details] [review]
Use git format-patch

Comment 3 Vinson Lee 2012-01-05 22:46:47 UTC

Thanks ojab. I've pushed the patch.


commit 2fe6c254f72628c22473800c5ce002d09391d102
Author: ojab <ojab@ojab.ru>
Date:   Thu Jan 5 14:18:34 2012 +0400

    Strip LLVM svn rev from `llvm-config --version` output.
    
    Reviewed-by: Vinson Lee <vlee@freedesktop.org>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.