Bug 4465 - Convolution parameters are not converted from XFixed in fbcompose.c
Summary: Convolution parameters are not converted from XFixed in fbcompose.c
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-15 06:35 UTC by Rich Wareham
Modified: 2010-08-09 12:43 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Proposed patch to fix the problem (963 bytes, patch)
2005-09-15 06:37 UTC, Rich Wareham 		no flags Details | Splinter Review
View All

Description Rich Wareham 2005-09-15 06:35:46 UTC 
In fb/fbcompose.c the implementation of convolution filters treats the
convolution coefficients as integers instead of fixed-point values. The result
is that convolution filters with fractional co-efficients are impossible to
specify. I'll attach a patch that fixes the problem.
Comment 1 Rich Wareham 2005-09-15 06:37:27 UTC 
Created attachment 3285 [details] [review]
Proposed patch to fix the problem

This patch shifts the result of multiplying to convolution coefficients with
the source component values in order to convert from a fixed-point
representation.
Comment 2 Daniel Stone 2007-02-27 01:28:03 UTC 
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 3 Adam Jackson 2010-08-09 12:43:22 UTC 
This appears to be fixed by 4365d16c8629e824973ee0c357efdfbfd28b672c.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.