Bug 44744 - duplicate struct declarations in osdep.h / io.c
Summary: duplicate struct declarations in osdep.h / io.c
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: medium minor
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-12 14:26 UTC by Pete Beardmore
Modified: 2012-01-14 03:00 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
config log (273.81 KB, application/octet-stream)
2012-01-12 14:26 UTC, Pete Beardmore
no flags Details
trivial fix (2.01 KB, patch)
2012-01-12 14:32 UTC, Pete Beardmore
no flags Details | Splinter Review

Description Pete Beardmore 2012-01-12 14:26:46 UTC
Created attachment 55526 [details]
config log

apparently slack-er compiler settings 'allow' (or ignore) this, but slack-ware's gcc 4.5.2 didn't

Making all in os
make[1]: Entering directory `..../xorg/xorg-x86/xserver/os'
  CC     io.lo
io.c:95:21: error: redefinition of typedef 'ConnectionInputPtr'
osdep.h:111:34: note: previous declaration of 'ConnectionInputPtr' was here
io.c:102:22: error: redefinition of typedef 'ConnectionOutputPtr'
osdep.h:112:35: note: previous declaration of 'ConnectionOutputPtr' was here
io.c: In function 'FlushAllOutput':
io.c:655:18: warning: declaration of 'index' shadows a global declaration
io.c: In function 'FlushClient':
io.c:951:2: warning: cast discards qualifiers from pointer target type
make[1]: *** [io.lo] Error 1
make[1]: Leaving directory `..../xorg/xorg-x86/xserver/os'
make: *** [all-recursive] Error 1
Comment 1 Pete Beardmore 2012-01-12 14:32:56 UTC
Created attachment 55527 [details] [review]
trivial fix


i moved the 'ConnectionInput' / 'ConnectionOutput' declarations to the osdep header too. somebody needs to check that for appropriateness. cheers
Comment 2 Julien Cristau 2012-01-14 03:00:41 UTC
I think that change was reverted in 5b9f5c8a53aca03c3c73bc10bd362987621a9d72


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.