Bug 44799 - Fallback images broken
Summary: Fallback images broken
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: general (show other bugs)
Version: 1.10.3
Hardware: Other All
: medium blocker
Assignee: Carl Worth
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: cairo-1.12
  Show dependency treegraph
 
Reported: 2012-01-15 05:44 UTC by Adrian Johnson
Modified: 2012-03-08 03:44 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Adrian Johnson 2012-01-15 05:44:17 UTC
When the fallback resolution != 72ppi the fallback image is incorrect.

When push/pop group is used a page size fallback image is used instead of finer grained fallbacks.

The test/fallback.c test will reproduce both bugs. This previously worked in 
59661f8a.
Comment 1 Chris Wilson 2012-02-22 11:57:54 UTC
commit 7e3c9631915b85acd915161cb2ba00cb24033e58
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Wed Feb 22 19:55:22 2012 +0000

    surface-wrapper: Transform the clip by the device-transform correctly
    
    Fixes paginated fallbacks.
    
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

A step at least in the right direction.
Comment 2 Chris Wilson 2012-03-08 03:44:14 UTC
Ok, not fully comprehending the fix, but it does appear to generate the correct output and importantly with no obvious regressions:

commit 5bd29eda63ee54daecfdfe36b12a1b6c4b592740
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Tue Mar 6 14:11:49 2012 +0000

    surface-wrapper: Only apply the wrapped transform to the scaled-font
    
    And not the device_transform of the target. This smells fishy, but
    appears to make the test suite happy.
    
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.