FTR this is android 4.0 (ICS) with the official "Talk" client

Full Gabble log is on http://people.collabora.com/~cassidy/gabble-44897.log

In my Wocky caps cache:


sqlite> select * from capabilities where node = 'http://www.android.com/gtalk/client/caps#voice-v1';
http://www.android.com/gtalk/client/caps#voice-v1|<?xml version="1.0" encoding="UTF-8"?>
<query xmlns="http://jabber.org/protocol/disco#info"><identity category="account" type="registered" name="Google Talk User Account"/><feature var="http://jabber.org/protocol/disco#info"/><feature var="http://jabber.org/protocol/disco#items"/></query>
|1326892667


Looks like we're facing the Google server bug described in client_types_from_message():

     /* So, turns out if you disco a specific resource of a gtalk
      contact, the Google servers will reply with the identity node as
      if you disco'd the bare jid, so will get something like:

          <identity category='account' type='registered' name='Google Talk User Account'/>

      which is just great. So, let's special case android phones as
      their resources will start with "android" and let's just say
      they're phones. */


Shouldn't we special case A/V caps as well?

Adding the lines:

gabble_presence_cache_add_bundle_caps (cache, \
      "http://www.android.com/gtalk/client/caps2#" cap, features); \

at src/presence-cache.c:508
makes gabble identify these contacts as a/v-callable.
However, calls are still not successful with this patch.

This is when the other end is an Asus Eeepad Transformer with Android 4.0 (ICS).

I commited a fix in the following git repo:
git@github.com:mlundblad/telepathy-gabble.git

But I guess since the actual calls are still failing, this is probably not yet worth integrating in mainline.

This has been fixed as of commit http://cgit.freedesktop.org/telepathy/telepathy-gabble/commit/?id=dad87309ae85ca4a45e393c1e351b309fc8097a6