Bug 45057 - MKDIR_P not defined and compiling fails
Summary: MKDIR_P not defined and compiling fails
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-21 14:59 UTC by gsr.bugs
Modified: 2012-01-21 19:48 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch extracted with git format-patch (4.20 KB, patch)
2012-01-21 14:59 UTC, gsr.bugs
Details | Splinter Review

Description gsr.bugs 2012-01-21 14:59:08 UTC
Created attachment 55933 [details] [review]
Patch extracted with git format-patch

As summary says, MKDIR_P is not defined and compiling fails with:

make[4]: Entering directory `.../src/mesa/drivers/dri'
Making all in swrast
make[5]: Entering directory `.../src/mesa/drivers/dri/swrast'
../../../../../lib;
/bin/bash: ../../../../../lib: Is a directory

All other uses go with lowercase mkdir_p instead of MKDIR_P.
Changing the Makefile.am files allows compilation to continue
and matches all other places that create a dir.
Comment 1 Matt Turner 2012-01-21 18:04:29 UTC
Does this patch fix it?

diff --git a/configure.ac b/configure.ac
index 4e5a1d3..656a8d9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -47,6 +47,7 @@ AC_PROG_CXX
 AC_CHECK_PROGS([MAKE], [gmake make])
 AC_CHECK_PROGS([PYTHON2], [python2 python])
 AC_PROG_SED
+AC_PROG_MKDIR_P
 AC_PATH_PROG([MKDEP], [makedepend])
 
 if test "x$MKDEP" = "x"; then
---
Comment 2 gsr.bugs 2012-01-21 19:17:52 UTC
That works too.
Comment 3 Matt Turner 2012-01-21 19:48:29 UTC
Thanks for reporting and testing. Fixed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.