Title pretty much says it all. They're pretty easy to generate from the GIR, so it would be nice to have them distributed with Poppler.
Created attachment 56114 [details] [review] glib: add Vala bindings
Created attachment 56311 [details] [review] glib: add Vala bindings Slightly updated version which corrects some field ownership issues.
Is this actually needed? We don't provide any bindings in poppler source code. Isn't it enough with the gobject-introspections stuff?
The Vala bindinds require additional information than just the GIR file and it's better for them to be distributed with poppler so they match.
You seem to be contradicting the original reporter, can you guys agree on wheter gir is enough or not?
(In reply to Albert Astals Cid from comment #5) > You seem to be contradicting the original reporter, can you guys agree on > wheter gir is enough or not? He isn't contradicting me at all. I only said it is *pretty easy* to generate them from the GIR, not that the GIR alone is enough. It requires a metadata file—the current version is at https://git.gnome.org/browse/vala/tree/vapi/metadata/Poppler-0.18.metadata We can keep distributing them with Vala, but there are a few problems; for one thing the Vala bindings will not necessarily match the version of poppler which is installed. See the beginning of https://wiki.gnome.org/Projects/Vala/UpstreamGuide for several other reasons.
This would make it easier to keep API changes in sync. For example Debian had a recent request to package 0.54 and noted "the Vala bindings could be updated, and then pdf-presenter-console could take advantage of the new API": http://linux.debian.bugs.dist.narkive.com/e4ouwHWb/bug-860955-poppler-please-package-new-upstream-version-0-54-0-as-soon-as-possible The current patch would need to be updated for CMake to check for vapigen.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/poppler/poppler/issues/341.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.