Bug 45270 - Wocky distcheck fails due to style issue
Summary: Wocky distcheck fails due to style issue
Status: RESOLVED FIXED
Alias: None
Product: Wocky
Classification: Unclassified
Component: General (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-26 07:11 UTC by Alvaro Soliverez
Modified: 2012-01-30 10:13 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Fix coding style so the tests can pass (782 bytes, patch)
2012-01-26 07:57 UTC, Simon McVittie 		Details | Splinter Review
View All

Description Alvaro Soliverez 2012-01-26 07:11:10 UTC 
It's throwing this error

../../tests/wocky-connector-test.c:3159:  WSAEventSelect( csock, 0, 0);
^^^ Our coding style is to use function calls like foo (), not foo()
make[3]: *** [check-coding-style] Error 1

http://buildbot.telepathy.im:8010/builders/Wocky%20-%20default%20-%20i386/builds/79/steps/Tests/logs/stdio
Comment 1 Simon McVittie 2012-01-26 07:57:44 UTC 
Created attachment 56188 [details] [review]
Fix coding style so the tests can pass
Comment 2 Guillaume Desmottes 2012-01-27 03:56:45 UTC 
Comment on attachment 56188 [details] [review]
Fix coding style so the tests can pass

Review of attachment 56188 [details] [review]:
-----------------------------------------------------------------

++

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.