Bug 45407 - Fails to build with mingw64's latest header
Summary: Fails to build with mingw64's latest header
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: glib frontend (show other bugs)
Version: unspecified
Hardware: All Windows (All)
: medium major
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-30 08:30 UTC by Hib Eris
Modified: 2012-01-30 11:40 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
0001-Fix-build-with-latest-mingw-w64-headers.patch (1016 bytes, patch)
2012-01-30 08:32 UTC, Hib Eris 		Details | Splinter Review
View All

Description Hib Eris 2012-01-30 08:30:44 UTC 
Compiling poppler fails with the mingw64 compiler using the latest mingw64 header files from vcs.

The cause for this is that these header files define time_t depending on (among others) the definition of _FILE_OFFSET_BITS, which is defined in config.h.

Now, config.h is included in poppler-attachment.cc, but not in poppler-document.cc and poppler-annot.cc, causing a mismatch in the time_t definition.

Including config.h in poppler-document.cc and poppler-annot.cc fixes this.

Patch will follow.
Comment 1 Hib Eris 2012-01-30 08:32:22 UTC 
Created attachment 56333 [details] [review]
0001-Fix-build-with-latest-mingw-w64-headers.patch
Comment 2 Hib Eris 2012-01-30 08:55:29 UTC 
Forgot to mention: this is for compiling using the mingw64 compiler but having win32 as the target, not win64.
Comment 3 Albert Astals Cid 2012-01-30 11:40:32 UTC 
Pushed

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.