When I build poppler with introspection, I get a lot of error output form GISCAN. Like this: make[4]: Entering directory `/home/janjos/Floss/checkouts/poppler/build/glib' CC poppler-enums.lo CXX poppler-action.lo CXX poppler-date.lo CXX poppler-document.lo CXX poppler-page.lo CXX poppler-attachment.lo CXX poppler-form-field.lo CXX poppler-annot.lo CXX poppler-layer.lo CXX poppler-media.lo CXX poppler-movie.lo CXX poppler.lo CXXLD libpoppler-glib.la GISCAN Poppler-0.18.gir /home/janjos/Floss/checkouts/poppler/glib/poppler-private.h:26: syntax error, unexpected identifier in ' PDFDoc *doc;' at 'PDFDoc' /home/janjos/Floss/checkouts/poppler/glib/poppler-private.h:30: syntax error, unexpected identifier in ' CairoOutputDev *output_dev;' at 'CairoOutputDev' /home/janjos/Floss/checkouts/poppler/glib/poppler-private.h:38: syntax error, unexpected identifier in ' PopplerDocument *document;' at 'PopplerDocument' /home/janjos/Floss/checkouts/poppler/glib/poppler-private.h:46: syntax error, unexpected '}' in '};' at '}' /home/janjos/Floss/checkouts/poppler/glib/poppler-private.h:52: syntax error, unexpected identifier in ' PopplerDocument *document;' at 'PopplerDocument' /home/janjos/Floss/checkouts/poppler/glib/poppler-private.h:60: syntax error, unexpected identifier in ' PopplerDocument *document;' at 'PopplerDocument' /home/janjos/Floss/checkouts/poppler/glib/poppler-private.h:63: syntax error, unexpected identifier in ' TextPage *text;' at 'TextPage' /home/janjos/Floss/checkouts/poppler/glib/poppler-private.h:70: syntax error, unexpected identifier in ' PopplerDocument *document;' at 'PopplerDocument' /home/janjos/Floss/checkouts/poppler/glib/poppler-private.h:78: syntax error, unexpected identifier in ' Annot *annot;' at 'Annot' /home/janjos/Floss/checkouts/poppler/glib/poppler-private.h:85: syntax error, unexpected identifier in ' OptionalContentGroup *oc;' at 'OptionalContentGroup' /home/janjos/Floss/checkouts/poppler/glib/poppler-private.h:92: syntax error, unexpected identifier in ' PopplerDocument *document;' at 'PopplerDocument' /home/janjos/Floss/checkouts/poppler/glib/poppler-private.h:96: syntax error, unexpected '}' in '};' at '}' /home/janjos/Floss/checkouts/poppler/glib/poppler-private.h:98: syntax error, unexpected '*', expecting ')' or ',' in 'GList *_poppler_document_get_layers (PopplerDocument *document);' at '*' /home/janjos/Floss/checkouts/poppler/glib/poppler-private.h:99: syntax error, unexpected '*', expecting ')' or ',' in 'GList *_poppler_document_get_layer_rbgroup (PopplerDocument *document,' at '*' /home/janjos/Floss/checkouts/poppler/glib/poppler-private.h:106: syntax error, unexpected ')', expecting ',' or ';' in ' const gchar *title);' at ')' /home/janjos/Floss/checkouts/poppler/glib/poppler-private.h:109: syntax error, unexpected ')', expecting ',' or ';' in ' GList *rbgroup);' at ')' /home/janjos/Floss/checkouts/poppler/glib/poppler-private.h:124: syntax error, unexpected '*', expecting ')' or ',' in 'char *_poppler_goo_string_to_utf8(GooString *s);' at '*' /home/janjos/Floss/checkouts/poppler/glib/poppler-private.h:125: syntax error, unexpected '*', expecting ')' or ',' in 'gboolean _poppler_convert_pdf_date_to_gtime (GooString *date,' at '*' /home/janjos/Floss/checkouts/poppler/glib/poppler-private.h:126: syntax error, unexpected ')', expecting ',' or ';' in ' time_t *gdate);' at ')' GICOMP Poppler-0.18.gir make[4]: Leaving directory `/home/janjos/Floss/checkouts/poppler/build/glib' Nevertheless, the build seems to work fine anyway. It would be nice if these errors are avoided, giving a cleaner build log.
Created attachment 56403 [details] [review] 0001-Exclude-poppler-private.h-from-introspection-files.patch Looking at how gtk does this, http://git.gnome.org/browse/gtk+/tree/gtk/Makefile.am#n1140 GTK excludes private headers from the introspection files. So, this patch does the same for poppler-private.h. I have no understanding of introspection what so ever, but this patch does not seem to alter the Poppler-0.18.gir output file.
Created attachment 56565 [details] [review] 0001-Exclude-poppler-private.h-from-introspection-files.patch Updated patch for cmake.
Pushed, thanks!
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.