Bug 45515 - Remove wocky_tls_session_add_crl() from API
Summary: Remove wocky_tls_session_add_crl() from API
Status: RESOLVED FIXED
Alias: None
Product: Wocky
Classification: Unclassified
Component: General (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Nicolas Dufresne
QA Contact: Telepathy bugs list
URL:
Whiteboard: review+
Keywords: patch
Depends on:
Blocks: 31447
  Show dependency treegraph
 
Reported: 2012-02-01 12:36 UTC by Nicolas Dufresne
Modified: 2012-04-03 15:15 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Remove wocky_tls_session_add_crl (17.10 KB, patch)
2012-02-01 13:33 UTC, Nicolas Dufresne
Details | Splinter Review

Description Nicolas Dufresne 2012-02-01 12:36:02 UTC
Certificate revocation list (CRL) is something generally controlled system wide, it's a bit pointless to control that per-application (unlike adding new custom CAs). This is not supported by GIO-tls, and not used in Gabble.

I suggest removing this API, which would allow merging the GIO-tls branch.
Comment 1 Nicolas Dufresne 2012-02-01 13:33:57 UTC
Created attachment 56472 [details] [review]
Remove wocky_tls_session_add_crl
Comment 2 Simon McVittie 2012-02-23 04:10:40 UTC
This seems reasonable. Sjoerd, do you want to look at this or should we just ship it?
Comment 3 Sjoerd Simons 2012-02-23 05:41:09 UTC
Ship it. If GIO-tls doesn't support it it's not very useful IMHO, given we want to move to that by default (can we yet, can we ? :))..
Comment 4 Nicolas Dufresne 2012-04-03 15:15:20 UTC
Pushed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.