Hi, I have some patches to improve the poppler-glib API docs.
Created attachment 56523 [details] [review] 0001-gtk-doc-Fix-typo-s.patch
Created attachment 56524 [details] [review] 0002-gtk-doc-do-not-build-doc-for-glib-demo.patch
Created attachment 56525 [details] [review] 0003-gtk-doc-remove-references-to-removed-pixbuf-function.patch
Created attachment 56526 [details] [review] 0004-gtk-doc-Add-more-glib-API-documentation-for-poppler-.patch
Created attachment 56527 [details] [review] 0005-NOT-SURE-ABOUT-THIS-gtk-doc-Fix-API-documentation-fo.patch
Created attachment 56528 [details] [review] 0006-ALSO-NOT-SURE-ABOUT-THIS-ONE-gtk-doc-Fix-API-documen.patch
Created attachment 56530 [details] [review] 0007-gtk-doc-Fix-build-when-builddir-srcdir.patch
Created attachment 56531 [details] [review] 0008-glib-Add-POPPLER_DISABLE_DEPRECATED-guards-around-de.patch
Comment on attachment 56527 [details] [review] 0005-NOT-SURE-ABOUT-THIS-gtk-doc-Fix-API-documentation-fo.patch Review of attachment 56527 [details] [review]: ----------------------------------------------------------------- ::: glib/poppler-document.cc @@ +2359,4 @@ > * @iter: a #PopplerLayersIter > * > * Returns the #PopplerLayer associated with @iter. It must be freed with > + * g_object_unref(). Yes, this is correct. Return value has the transfer full annotation and it says it returns a new #PopplerLayer, which is a GObject, so I think it's obvious you have to use g_object_unref(), so I've simply removed the whole sentence.
Comment on attachment 56528 [details] [review] 0006-ALSO-NOT-SURE-ABOUT-THIS-ONE-gtk-doc-Fix-API-documen.patch Review of attachment 56528 [details] [review]: ----------------------------------------------------------------- This is correct
Comment on attachment 56531 [details] [review] 0008-glib-Add-POPPLER_DISABLE_DEPRECATED-guards-around-de.patch Review of attachment 56531 [details] [review]: ----------------------------------------------------------------- I prefer to follow glib/gtk approach of using compile warnings, gtk-doc warnings about deprecation guards are harmless anyway.
Pushed everything except the deprecation guards patch. Thank you very much!
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.