I found that Salut doesn't use TpBaseChannel once. The horror. I "fixed" a few channel objects. I didn't touch the tube{,s} stuff because it gets hairy there as those objects handle both TargetHandleType=CONTACT and TargetHandleType=ROOM which TpBaseChannel doesn't really like, so we need to split out the MUC version into another tiny base class. I didn't bother as we're going to remove Tubes soon anyway, and well, blah blah blah.
IM ++
MUC ++ with or without fixing these trivia: > + g_object_get (base_conn, "self", &(priv->self), NULL); Pre-existing nit: I'd have preferred one property-pair per line, but whatever. > + g_object_get (G_OBJECT (conn), "contact-manager", > &contact_manager, NULL); Likewise here
FT ++
RoomList ++, so, all ++ with optional trivia in Comment #2. If you wanted to do the Tube channels too, as you did for Gabble in Bug #46502, I wouldn't say no.
(In reply to comment #2) > MUC ++ with or without fixing these trivia: > > > + g_object_get (base_conn, "self", &(priv->self), NULL); > > Pre-existing nit: I'd have preferred one property-pair per line, but whatever. > > > + g_object_get (G_OBJECT (conn), "contact-manager", > > &contact_manager, NULL); > > Likewise here Fixed these. (In reply to comment #4) > RoomList ++, so, all ++ with optional trivia in Comment #2. > > If you wanted to do the Tube channels too, as you did for Gabble in Bug #46502, > I wouldn't say no. Some other day. Merged, thanks for the review!
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.