(deliberately no patch keyword for now, but feel free to review so far) Gabble should use TpBaseChannel more. Here are some patches to make do exactly that. I've still got GabbleTubeStream to split up too but I thought I'd just post my progress for the time being here. After this I'll be removing Tubes channels. I just wish they weren't so tangled into everything in Gabble and Salut. :-(
Okay, I finished this. What do you think? 86 files changed, 902 insertions(+), 1973 deletions(-)
(In reply to comment #1) > 86 files changed, 902 insertions(+), 1973 deletions(-) Oh this is wrong, ignore it please.
FT ++
All ++. Other things you could do if you felt like it: - make TpBaseChannel officially a prerequisite of the Tube GInterface - try extracting a superclass for the two Tube channels Those might be too much to bother with right now, though.
(In reply to comment #4) > Those might be too much to bother with right now, though. lol no thanks. Merged!
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.