Here's the patching I did to make my trackpad work. Without them, the mouse and touch events would randomly report wrong coordinates and make everything unusable.
Created attachment 56637 [details] [review] eventcomm: Fix initialization code
Created attachment 56638 [details] [review] eventcomm: Make code work without custom valuator Instead, always use the valuator for the current touchpoint directly. Fixes crazy pointer jumps with Apple Magic Trackpad.
First patch looks good, though i've expanded the commit message a bit. Second patch I'll defer for Chase for now.
I agree on the first patch. The second patch removes the functionality that ensures unchanged values are not sent in XI 2.x events. It is likely just papering over bad behavior in the server or client.
Comment on attachment 56637 [details] [review] eventcomm: Fix initialization code Review of attachment 56637 [details] [review]: ----------------------------------------------------------------- commit da0d20d0fd5cce3707b54146e54e2df0c697e1b4 Author: Benjamin Otte <otte@redhat.com> Date: Mon Feb 6 00:45:23 2012 +0100 eventcomm: Fix initialization code
Comment on attachment 56637 [details] [review] eventcomm: Fix initialization code Review of attachment 56637 [details] [review]: ----------------------------------------------------------------- I'm not sure if I need to make a review here, but just to be sure: Reviewed-by: Chase Douglas <chase.douglas@canonical.com>
commit da0d20d0fd5cce3707b54146e54e2df0c697e1b4 Author: Benjamin Otte <otte@redhat.com> Date: Mon Feb 6 00:45:23 2012 +0100 eventcomm: Fix initialization code
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.