Bug 45704 - Update for Wocky's new single header.
Summary: Update for Wocky's new single header.
Status: RESOLVED FIXED
Alias: None
Product: Ytstenut
Classification: Unclassified
Component: plugins (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Robert Staudinger
QA Contact:
URL:
Whiteboard: review+
Keywords:
Depends on: 45703
Blocks:
  Show dependency tree / graph
 
Reported: 2012-02-06 07:48 UTC by Will Thompson
Modified: 2012-02-14 03:05 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:

Attachments
oh yeah! a patch! (4.95 KB, patch)
2012-02-06 08:43 UTC, Will Thompson 		Details | Splinter Review
View All

Description Will Thompson 2012-02-06 07:48:14 UTC 
I made Wocky have a single header, <wocky/wocky.h>. Here's a patch to update ytstenut-plugins accordingly. (I haven't actually tried to compile it but I don't see why it wouldn't work once the corresponding Salut patch on bug 45703 is merged.)
Comment 1 Will Thompson 2012-02-06 08:43:37 UTC 
Created attachment 56682 [details] [review]
oh yeah! a patch!
Comment 2 Robert Staudinger 2012-02-06 12:59:45 UTC 
While generally Olli would probably be approximately a bajillion times more adequate to review patches, I am not entirely disinclined to stick out my neck on this occasion, given the nature of the patch.
Comment 3 Robert Staudinger 2012-02-06 13:00:26 UTC 
Also my "+" key is a bit too close to "return".
Comment 4 Robert Staudinger 2012-02-14 02:34:24 UTC 
I rebuilt against gabble and salut master today, and it worked out just fine without this patch. What did I mess up?
Comment 5 Will Thompson 2012-02-14 03:05:40 UTC 
(In reply to comment #4)
> I rebuilt against gabble and salut master today, and it worked out just fine without this patch. What did I mess up?

I messed up and forgot to close this bug when I merged the patch. http://cgit.freedesktop.org/ytstenut/ytstenut-plugins/commit/?id=6fc6b0ab33cf16b998cbc29b04bcdd47eaec1090

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.