Bug 45840 - Improve moc detection when cross compiling
Summary: Improve moc detection when cross compiling
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-09 07:36 UTC by Hib Eris
Modified: 2012-02-12 14:16 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
0001-Improve-moc-detection-when-cross-compiling.patch (1.05 KB, patch)
2012-02-09 07:36 UTC, Hib Eris 		Details | Splinter Review
View All

Description Hib Eris 2012-02-09 07:36:00 UTC 
Created attachment 56821 [details] [review]
0001-Improve-moc-detection-when-cross-compiling.patch

Use AC_CHECK_TOOL instead of `which moc`.

This makes cross compiling easier.
Comment 1 Albert Astals Cid 2012-02-09 13:17:45 UTC 
seems like you should remove the AC_MSG_CHECKING + AC_MSG_RESULT pairs then?
Comment 2 Hib Eris 2012-02-10 00:31:50 UTC 
(In reply to comment #1)
> seems like you should remove the AC_MSG_CHECKING + AC_MSG_RESULT pairs then?

I actually left them in there because checking for moc and checking that the moc is for qt4 are two different checks.
Comment 3 Albert Astals Cid 2012-02-12 14:16:17 UTC 
Ok, i see some hidden truth in there.

Commited.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.