mesa: 094eeff19946138d6306d74e9e62af5e9d192abd (master) Run piglit getteximage-invalid-format-for-packed-type on softpipe or llvmpipe. The test now fails but previously passed. $ ./bin/getteximage-invalid-format-for-packed-type -auto Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_OPERATION in glGetTexImage(format/type) Mesa: User error: GL_INVALID_ENUM in glGetTexImage(format/type) PIGLIT: {'result': 'fail' } 627b435dfe17698a1c69e9a259838fc6f2e6bd4e is the first bad commit commit 627b435dfe17698a1c69e9a259838fc6f2e6bd4e Author: Brian Paul <brianp@vmware.com> Date: Tue Feb 7 07:42:33 2012 -0700 mesa: new _mesa_error_check_format_and_type() function This replaces the _mesa_is_legal_format_and_type() function. According to the spec, some invalid format/type combinations to glDrawPixels, ReadPixels and glTexImage should generate GL_INVALID_ENUM but others should generate GL_INVALID_OPERATION. With the old function we didn't make that distinction and generated GL_INVALID_ENUM errors instead of GL_INVALID_OPERATION. The new function returns one of those errors or GL_NO_ERROR. This will also let us remove some redundant format/type checks in follow-on commit. v2: add more checks for ARB_texture_rgb10_a2ui at the top of _mesa_error_check_format_and_type() per Ian. Signed-off-by: Brian Paul <brianp@vmware.com>
Fixed with commit 000ef7d9eab78132bea369b6b260e12b0baab79d
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.