Bug 4602 - cairo use of 0x0 images causes backend failure
Summary: cairo use of 0x0 images causes backend failure
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: win32 backend (show other bugs)
Version: 1.0.0
Hardware: x86 (IA32) Windows (All)
: high normal
Assignee: Owen Taylor
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-26 16:09 UTC by tor
Modified: 2005-09-26 21:53 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
don't try creating 0x0 images, similar to cworth's xlib fix (1.02 KB, patch)
2005-09-26 16:10 UTC, tor
Details | Splinter Review

Description tor 2005-09-26 16:09:34 UTC
Cairo occasionally tries to create 0x0 images, which causes
_create_dc_and_bitmap to fail and cairo to stop rendering.
Comment 1 tor 2005-09-26 16:10:25 UTC
Created attachment 3411 [details] [review]
don't try creating 0x0 images, similar to cworth's xlib fix
Comment 2 Carl Worth 2005-09-26 17:16:03 UTC
The fix looks fine to me.

There might be some higher-layer place to catch this, but when I looked at
fixing the similar xlib bug at higher layers it turned out to be much harder
that just this style of fix.

Why don't you go ahead and commit this to HEAD and BRANCH_1_0.
Comment 3 Carl Worth 2005-09-27 14:53:40 UTC
2005-09-27  T Rowley  <tim.rowley@gmail.com>

        * ROADMAP: Note that Bug #4602 (use of 0x0 images
        causes win32 backend failure) is now fixed.

        * src/cairo-win32-surface.c (_create_dc_and_bitmap):
        Avoid creating size-0 bitmap, which fails.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.