Created attachment 57057 [details] [review] add -list option to pdfimages The attached path adds a '-list' option to pdfimages to list all images in a pdf. It produces output like: page num type width height color comp bpc enc interp object ID --------------------------------------------------------------------- 1 0 image 1760 1248 gray 1 8 jpeg no 1815 0 1 1 mask 3520 2496 - 1 1 jbig2 no 1812 0 2 2 image 1760 1248 gray 1 8 jpeg no 8 0 2 3 mask 3520 2496 - 1 1 jbig2 no 10 0 3 4 image 1760 1248 gray 1 8 jpeg no 15 0 3 5 mask 3520 2496 - 1 1 jbig2 no 17 0 4 6 image 1760 1248 gray 1 8 jpeg no 22 0 4 7 mask 3520 2496 - 1 1 jbig2 no 24 0
ImageOutputDev::listImage has "Object obj;" that seems unused You added two unnneded empty lines to utils/ImageOutputDev.h i'm confused by the "if (listImages) {" inside ImageOutputDev::writeMask, isn't it always called in an else of listImages?
Created attachment 57067 [details] [review] add -list option to pdfimages updated patch
You still have "Object obj;" in ImageOutputDev::listImage that seems unused
Created attachment 57177 [details] [review] updated patch
Almost good now :D Remove the , after imgSmask and commit to master :-)
Committed
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.