Bug 46387 - tidy up Call implementation
Summary: tidy up Call implementation
Status: RESOLVED MOVED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard: Call
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-21 03:47 UTC by Simon McVittie
Modified: 2019-12-03 19:55 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Simon McVittie 2012-02-21 03:47:23 UTC
There are various FIXME comments in the Call implementation which need looking at by someone who understands this stuff:

+ /* FIXME: no idea... */
+ md = tp_call_content_media_description_new (
+ tp_base_connection_get_dbus_daemon (conn), path, handle,
+ (content != NULL), (content == NULL));

+ tp_call_content_media_description_append_codec (md,
+ c->id, c->name, c->clockrate, c->channels,
+ FALSE, /* FIXME: updated?? */
+ c->params);

+ /* FIXME: We have to handle cases where the new codecs are rejected */
+ tp_base_media_call_content_offer_media_description_async (
+ TP_BASE_MEDIA_CALL_CONTENT (self), md, NULL, NULL);

+ /* FIXME: correct??? */
+ contact = gabble_call_member_get_handle (
+ gabble_call_member_content_get_member (mcontent));
+ tp_md = tp_base_media_call_content_get_local_media_description (
+ TP_BASE_MEDIA_CALL_CONTENT (self), contact);
+ if (tp_md != NULL)
+ {
+ md->codecs = codec_array_to_list (tp_asv_get_boxed (tp_md,
+ TP_PROP_CALL_CONTENT_MEDIA_DESCRIPTION_CODECS,
+ TP_ARRAY_TYPE_CODEC_LIST));

+ /* FIXME: remote_contact==0 ??? */
+ tp_md = tp_base_media_call_content_get_local_media_description (content,
+ 0);
+ codecs = tp_asv_get_boxed (tp_md,
+ TP_PROP_CALL_CONTENT_MEDIA_DESCRIPTION_CODECS,
+ TP_ARRAY_TYPE_CODEC_LIST);

+ /* FIXME: remote_contact==0 ??? */
+ tp_md = tp_base_media_call_content_get_local_media_description (
+ TP_BASE_MEDIA_CALL_CONTENT (content), 0);
+ codecs = tp_asv_get_boxed (tp_md,
+ TP_PROP_CALL_CONTENT_MEDIA_DESCRIPTION_CODECS,
+ TP_ARRAY_TYPE_CODEC_LIST);

+ /* FIXME: ice??? */
+ endpoint = tp_call_stream_endpoint_new (bus, path, type, FALSE);
Comment 1 GitLab Migration User 2019-12-03 19:55:49 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-gabble/issues/213.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.