Bug 46471 - methods returning GStrv aren't introspectable
Summary: methods returning GStrv aren't introspectable
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2012-02-22 10:40 UTC by Simon McVittie
Modified: 2012-04-12 04:28 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Annotate GStrv as (array zero-terminated=1) for introspectability (2.66 KB, patch)
2012-02-22 10:41 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2012-02-22 10:40:40 UTC
16:40 < kuuko> Is the tp-glib function 
               tp_connection_manager_dup_protocol_names() named differently 
               when accessing it from python?

It turns out it's not accessible at all, because (type GObject.Strv) isn't understood. TpConnectionManager.protocols isn't understood by introspection, so that's no help either.

Open question for reviewers: should we take this opportunity to apply "Rename to: get_foo" to the affected dup_foo() methods, and should we apply that annotation to dup_foo() methods in future? The get/dup duality isn't really relevant for g-i.
Comment 1 Simon McVittie 2012-02-22 10:41:09 UTC
Created attachment 57475 [details] [review]
Annotate GStrv as (array zero-terminated=1) for  introspectability

(type GObject.Strv) isn't understood.

This affects tp_account_update_parameters_finish,
tp_connection_manager_dup_protocol_names,
tp_connection_manager_protocol_dup_param_names
and tp_protocol_dup_param_names.
Comment 2 Simon McVittie 2012-04-11 03:29:52 UTC
(In reply to comment #0)
> Open question for reviewers: should we take this opportunity to apply "Rename
> to: get_foo" to the affected dup_foo() methods ... ?

No, we shouldn't, because that doesn't work unless get_foo() also exists.
Comment 3 Jonny Lamb 2012-04-11 08:58:32 UTC
Comment on attachment 57475 [details] [review]
Annotate GStrv as (array zero-terminated=1) for  introspectability

Review of attachment 57475 [details] [review]:
-----------------------------------------------------------------

Go go go.
Comment 4 Simon McVittie 2012-04-12 04:28:06 UTC
Fixed in 0.19.0


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.