Created attachment 57479 [details] Patch to libXpm-3.5.9 for 64-bit build (and misc. windows ifdef's) I've been building Vim (which uses libXPM) on Win7x64. The XPM library assumed that sizeof(long) == sizeof(void*). In addition, I found I had to make a few other ifdef'ed changes to compile with microsoft's 'cl' compiler on windows. The patch is quick & dirty. I do not have the time to properly understand what the code is doing... it should probably use a union rather than making the assumption it does. Please pass this on to whomever maintains the XPM library. At a minimum, the patch to src/XpmI.h is required for 64-bit builds otherwise the library crashes. Thank you.
Created attachment 57498 [details] [review] Nmakefile and DLL export defs For completeness, add Nmakefile & DLL export defs
sizeof(long) == sizeof(void*) on Unix platforms in 64-bit mode, it's just Windows that decided to be different.
(In reply to comment #2) > sizeof(long) == sizeof(void*) on Unix platforms in 64-bit mode, it's > just Windows that decided to be different. Didn't realize that, thanks for the info. However, since there are already windows specific ifdef's, and future windows users will need the fix (for instance, if they want to compile a 64-bit VIM), would you consider at least patching Xpmi.h with my previously submitted patch or something similar? Thank you.
Don't worry, it's still in the queue for consideration when time allows, which is why this bug was just corrected and not yet closed. (libXpm has no active maintainer, so it gets dealt with by community members in their spare time, and may take a bit longer for patches to go through.)
Mass closure: This bug has been untouched for more than six years, and is not obviously still valid. Please reopen this bug or file a new report if you continue to experience issues with current releases.
Thanks for the patch, sorry for the delay. Pushed to git master: To ssh://gitlab.freedesktop.org/xorg/lib/libXpm e42ca7b..bc1b496 master -> master
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.