Bug 4660 - "cairo.def" doesn't reflect cairo-features.h
Summary: "cairo.def" doesn't reflect cairo-features.h
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: win32 backend (show other bugs)
Version: 1.0.0
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Owen Taylor
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-01 12:29 UTC by Mathias Hasselmann
Modified: 2006-06-13 23:42 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Consult "cairo-features.h" when generating "cairo.def" (1004 bytes, patch)
2005-10-01 12:30 UTC, Mathias Hasselmann 		Details | Splinter Review
View All

Description Mathias Hasselmann 2005-10-01 12:29:23 UTC 
When generating "cairo.def" a fixed set of features is considered without
consulting "cairo-features.h". This is harmfull, if you compile cairo for Win32
with a custom feature set, like for instance PDF backend enabled.

The attached patch uses "sed" to extract defines from "cairo-features.h".
Comment 1 Mathias Hasselmann 2005-10-01 12:30:41 UTC 
Created attachment 3459 [details] [review]
Consult "cairo-features.h" when generating "cairo.def"
Comment 2 Christian Biesinger 2006-04-23 03:28:46 UTC 
this was fixed differently in c2c4f0bb251423737d46fcde7ffe8711547abf09 (although
not for 1.0.x)
Comment 3 Behdad Esfahbod 2006-06-13 23:42:53 UTC 
This is already fixed by including cairo-features.h in the gcc command.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.