Bugzilla – Bug 46632
Make the alignment checks for the readpixel blit fastpath a bit more lenient
Last modified: 2013-02-14 02:38:47 UTC
Created attachment 57647 [details] [review]
intel_read_pixel: Accept alignments that are equivalent to 1
When deciding whether to use the blitter to implement the read pixels,
it had a restriction that pack->Alignment must be 1. However it should
at least be possible to accept alignments that are equivalent to 1.
For example, if the rowLength is 4 for an image with 4 cpp then the
rowstride is a multiple of 8 so none of the alignment values will
affect the rowstride and they are all equivalent.
Author: Eric Anholt <firstname.lastname@example.org>
Date: Wed Feb 6 17:03:49 2013 -0800
intel: Allow blit readpixels even when the pack alignment is set.
The default alignment is 4, so this fast path was rarely hit. Rather
than introduce logic to handle alignment, just use the Mesa core
Reviewed-by: Kenneth Graunke <email@example.com>