Bug 4672 - The gradient stops are not sorted.
Summary: The gradient stops are not sorted.
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: pdf backend (show other bugs)
Version: 1.1.1
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Kristian Høgsberg
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-03 06:57 UTC by Jens Taprogge
Modified: 2005-10-06 20:22 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Fix and partial support for multistop. (6.78 KB, patch)
2005-10-03 07:02 UTC, Jens Taprogge
Details | Splinter Review

Description Jens Taprogge 2005-10-03 06:57:47 UTC
Depending on the order the gradients are added this can result in the gradient
being rendered in the opposite direction.
Comment 1 Jens Taprogge 2005-10-03 07:02:54 UTC
Created attachment 3467 [details] [review]
Fix and partial support for multistop.

The attached patch fixes the problem in the same way it is done in
cairo-pattern.c and adds support for multiple stops at the same time.

The multistop part is however flawed. It assumes that the stops are evenly
spaced, which of course is not correct. This can be corrected using PDF's
stiching funtions (Type 3) quite easyly.

I will provide an additional patch as time permits.
Comment 2 Kristian Høgsberg 2005-10-07 13:22:01 UTC
Nice work, thanks.  I've committed your patch with a few stylistic changes. 
It's a obvious improvement over what's there now, but as you say, we still need
to handle non-uniformly spaced color stops.  If want to take a stab at that,
that'd  be great.

Thanks again.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.