Bug 46814 - do not check for /etc/debian_version before using xdg-open
Summary: do not check for /etc/debian_version before using xdg-open
Status: RESOLVED FIXED
Alias: None
Product: Portland
Classification: Unclassified
Component: xdg-utils (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Portland Bugs
QA Contact:
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2012-03-01 03:20 UTC by arno
Modified: 2012-08-09 13:10 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
patch proposal (1.61 KB, patch)
2012-03-01 03:20 UTC, arno
Details | Splinter Review

Description arno 2012-03-01 03:20:06 UTC
Created attachment 57854 [details] [review]
patch proposal

Hi,

currently, xdg-open uses run-mailcap if it's available on the system (checked with which command), and if it's a debian system (checked with /etc/debian_version).

But copying run-mailcap from a debian system to a non debian linux system works fine. So maybe, the check for /etc/debian_version is not necessary. That would also for other distributions to use it and/or for someone to put the run-mailcap script in its path (which is what I'm currently doing).
Comment 1 Rex Dieter 2012-03-02 10:42:22 UTC
I personally consider the use of legacy mailcap largely a hack, rather than trying other methods that follow xdg specs, see bug #45295 for example.

before considering marking this wontfix, let's see how others feel... anyone else have an opinion here?
Comment 2 Rex Dieter 2012-08-09 13:10:52 UTC
I guess no one else cares,  but looks harmless  enough.  applied,

http://cgit.freedesktop.org/xdg/xdg-utils/commit/?id=dc57720f8f9dbca412c132c6f8db9d6e0d6997de


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.