The attached patch moves -DGLX_DIRECT_RENDERING, -DUSE_XCB, -DHAVE_ALIAS to src/glx/x11/Makefile. GLX_DIRECT_RENDERING would be used in src/mesa but is not anymore, thus this is possible. These variable would be turned on/off with specialized config files linux-indirect and linux-x86-xcb. The same effect is now achieved by un/commenting the respective lines in Makefile, the user need not change config file to recompile libGL. Moreover these variables can now be used with whatever dri configuration of os/arch. Lastly, it is possible to kill the two config files linux-indirect and linux-x86-xcb.
Created attachment 3514 [details] [review] move glx related define's from configs/ to src/glx/x11/Makefile
How is it more convenient to have to dig for something in some Makefile to change your configuration rather than changing the known configuration location of configs/?
(In reply to comment #2) > How is it more convenient to have to dig for something in some Makefile to > change your configuration rather than changing the known configuration location > of configs/? My personal scenario is that I have a main DRI tree configured for my os/arch. If I want to use this tree to compile indirect or xcb, I make clean and make in glx/x11, I need not "reconfigure" my tree. If I want a dedicated tree for indirect or xcb, I need not duplicate the whole tree, I duplicate glx/x11 to glx/xcb and make, no need to change the LD variables to point to new locations also. Anyway ...
Of marginal interest. Closing.
Mass version move, cvs -> git
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.