Bug 47175 - piglit fbo-alphatest-formats regression
Summary: piglit fbo-alphatest-formats regression
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-09 22:38 UTC by Vinson Lee
Modified: 2012-03-12 11:24 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Vinson Lee 2012-03-09 22:38:32 UTC
mesa: 60218b604ae3422983dd1cd24f5d913e18f73ac0 (master)

piglit fbo-alphatest-formats has regressed on softpipe and llvmpipe.

$ ./bin/fbo-alphatest-formats -auto
Using test set: Core formats
Testing 3
Testing 4
Testing GL_RGB
Testing GL_RGBA
Testing GL_ALPHA
Testing GL_LUMINANCE
  FAIL when testing FBO result, 1: 0.2 < 0.25.
  FAIL when testing FBO result, 3: 0.6 > 0.55.
  FAIL when testing FBO result, 4: 0.9 > 0.1.
  FAIL when testing FBO result, 6: 0.4 == 0.4.
Testing GL_LUMINANCE_ALPHA
  FAIL when testing FBO result, 1: 0.2 < 0.25.
  FAIL when testing FBO result, 3: 0.6 > 0.55.
  FAIL when testing FBO result, 4: 0.9 > 0.1.
  FAIL when testing FBO result, 6: 0.4 == 0.4.
Testing GL_INTENSITY
  FAIL when testing FBO result, 1: 0.2 < 0.25.
  FAIL when testing FBO result, 3: 0.6 > 0.55.
  FAIL when testing FBO result, 4: 0.9 > 0.1.
  FAIL when testing FBO result, 6: 0.4 == 0.4.
Testing GL_ALPHA4
Testing GL_ALPHA8
Testing GL_ALPHA12
Testing GL_ALPHA16
Testing GL_LUMINANCE4
  FAIL when testing FBO result, 1: 0.2 < 0.25.
  FAIL when testing FBO result, 3: 0.6 > 0.55.
  FAIL when testing FBO result, 4: 0.9 > 0.1.
  FAIL when testing FBO result, 6: 0.4 == 0.4.
Testing GL_LUMINANCE8
  FAIL when testing FBO result, 1: 0.2 < 0.25.
  FAIL when testing FBO result, 3: 0.6 > 0.55.
  FAIL when testing FBO result, 4: 0.9 > 0.1.
  FAIL when testing FBO result, 6: 0.4 == 0.4.
Testing GL_LUMINANCE12
  FAIL when testing FBO result, 1: 0.2 < 0.25.
  FAIL when testing FBO result, 3: 0.6 > 0.55.
  FAIL when testing FBO result, 4: 0.9 > 0.1.
  FAIL when testing FBO result, 6: 0.4 == 0.4.
Testing GL_LUMINANCE16
  FAIL when testing FBO result, 1: 0.2 < 0.25.
  FAIL when testing FBO result, 3: 0.6 > 0.55.
  FAIL when testing FBO result, 4: 0.9 > 0.1.
  FAIL when testing FBO result, 6: 0.4 == 0.4.
Testing GL_LUMINANCE4_ALPHA4
  FAIL when testing FBO result, 1: 0.2 < 0.25.
  FAIL when testing FBO result, 3: 0.6 > 0.55.
  FAIL when testing FBO result, 4: 0.9 > 0.1.
  FAIL when testing FBO result, 6: 0.4 == 0.4.
Testing GL_LUMINANCE8_ALPHA8
  FAIL when testing FBO result, 1: 0.2 < 0.25.
  FAIL when testing FBO result, 3: 0.6 > 0.55.
  FAIL when testing FBO result, 4: 0.9 > 0.1.
  FAIL when testing FBO result, 6: 0.4 == 0.4.
Testing GL_LUMINANCE12_ALPHA12
  FAIL when testing FBO result, 1: 0.2 < 0.25.
  FAIL when testing FBO result, 3: 0.6 > 0.55.
  FAIL when testing FBO result, 4: 0.9 > 0.1.
  FAIL when testing FBO result, 6: 0.4 == 0.4.
Testing GL_LUMINANCE16_ALPHA16
  FAIL when testing FBO result, 1: 0.2 < 0.25.
  FAIL when testing FBO result, 3: 0.6 > 0.55.
  FAIL when testing FBO result, 4: 0.9 > 0.1.
  FAIL when testing FBO result, 6: 0.4 == 0.4.
Testing GL_INTENSITY4
  FAIL when testing FBO result, 1: 0.2 < 0.25.
  FAIL when testing FBO result, 3: 0.6 > 0.55.
  FAIL when testing FBO result, 4: 0.9 > 0.1.
  FAIL when testing FBO result, 6: 0.4 == 0.4.
Testing GL_INTENSITY8
  FAIL when testing FBO result, 1: 0.2 < 0.25.
  FAIL when testing FBO result, 3: 0.6 > 0.55.
  FAIL when testing FBO result, 4: 0.9 > 0.1.
  FAIL when testing FBO result, 6: 0.4 == 0.4.
Testing GL_INTENSITY12
  FAIL when testing FBO result, 1: 0.2 < 0.25.
  FAIL when testing FBO result, 3: 0.6 > 0.55.
  FAIL when testing FBO result, 4: 0.9 > 0.1.
  FAIL when testing FBO result, 6: 0.4 == 0.4.
Testing GL_INTENSITY16
  FAIL when testing FBO result, 1: 0.2 < 0.25.
  FAIL when testing FBO result, 3: 0.6 > 0.55.
  FAIL when testing FBO result, 4: 0.9 > 0.1.
  FAIL when testing FBO result, 6: 0.4 == 0.4.
Testing GL_R3_G3_B2
Testing GL_RGB4
Testing GL_RGB5
Testing GL_RGB8
Testing GL_RGB10
Testing GL_RGB12
Testing GL_RGB16
Testing GL_RGBA2
Testing GL_RGBA4
Testing GL_RGB5_A1
Testing GL_RGBA8
Testing GL_RGB10_A2
Testing GL_RGBA12
Testing GL_RGBA16
PIGLIT: {'result': 'fail' }
Comment 1 Vinson Lee 2012-03-09 22:50:19 UTC
ad897fff7730298c21289768d9b1b55f3d166ac5 is the first bad commit
commit ad897fff7730298c21289768d9b1b55f3d166ac5
Author: Brian Paul <brianp@vmware.com>
Date:   Wed Feb 29 20:55:50 2012 -0700

    mesa: use _mesa_rebase_rgba_float/uint() in glReadPixels code
    
    See the comments for _mesa_rebase_rgba_float() for details.
    Fixes https://bugs.freedesktop.org/show_bug.cgi?id=46679
    
    NOTE: This is a candidate for the 8.0 branch.
    
    Reviewed-by: José Fonseca <jfonseca@vmware.com>
Comment 2 Brian Paul 2012-03-12 09:02:10 UTC
Actually, I think mesa is right and the test is wrong.  The NVIDIA driver fails the same tests as Mesa.  It looks like the test is doing the wrong thing when computing the expected result colors when the texture is luminance, L/A or intensity.

I'll try to fix that.
Comment 3 Brian Paul 2012-03-12 11:24:22 UTC
Fixed with commit 731669c0667325f311fcbcd0f1be63801faaec82 to piglit.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.