Documentation of tp_call_content_media_description_append_codec() is pretty lame, all its arguments have "if you use this API, you know what it is about" as doc. We should re-use the doc from the spec at the very least. This is true for tp_call_content_media_description_add_ssrc() as well.
Created attachment 58951 [details] [review] CallContentMediaDescription: Add missing documentation
Comment on attachment 58951 [details] [review] CallContentMediaDescription: Add missing documentation Review of attachment 58951 [details] [review]: ----------------------------------------------------------------- ::: telepathy-glib/call-content-media-description.c @@ +729,2 @@ > * > + * Add an SSRC to the list of SSRCs that a contact will send from Trailing '.' missing. A small explanation of what a SSRC is and how it would be used may be useful for newbies like me. @@ +768,5 @@ > + * @name: The name of the codec. > + * @clock_rate: The clock rate of the codec. > + * @channels: Number of channels of the codec if applicable, otherwise 0. > + * @updated: %TRUE if this codec was updated since the last Media Description > + * @parameters: a #GHashTable of string->string containing optional parameters This arg should be annotated to make gi happy.
Created attachment 59114 [details] [review] CallContentMediaDescription: Add missing documentation (updated) I've added a . and a little explanation of what a SSRC is. I haven't added any GI as this is CM-side.
Comment on attachment 59114 [details] [review] CallContentMediaDescription: Add missing documentation (updated) Review of attachment 59114 [details] [review]: ----------------------------------------------------------------- ++
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-glib/issues/85.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.