Bug 47868 - rhdAtomFirmwareInfoQuery returns incorrect minimum pixel clock pll output
Summary: rhdAtomFirmwareInfoQuery returns incorrect minimum pixel clock pll output
Status: RESOLVED INVALID
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Radeon (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: xf86-video-ati maintainers
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-25 14:54 UTC by Sebastian D'Alessandro
Modified: 2018-06-12 19:06 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
the patch (3.72 KB, patch)
2012-03-26 12:35 UTC, Sebastian D'Alessandro
no flags Details | Splinter Review

Description Sebastian D'Alessandro 2012-03-25 14:54:31 UTC
In file radeon_atombios.c, function rhdAtomFirmwareInfoQuery, for firmware content revisions 2,3 and 4, usMinPixelClockPLL_Output is used instead of ulMinPixelClockPLL_Output and le16_to_cpu should be changed to le32_to_cpu for those cases.
Comment 1 Sebastian D'Alessandro 2012-03-25 17:48:45 UTC
The same bug is in radeonhd driver, file rhd_atombios.c, function rhdAtomFirmwareInfoQuery. Should I create an identical bug report in radeonhd category?
Comment 2 Michel Dänzer 2012-03-26 01:00:42 UTC
(In reply to comment #1)
> Should I create an identical bug report in radeonhd category?

Probably not, the radeonhd driver isn't being actively developed anymore.

Can you create a Git patch fixing the problem and send it to the xorg-driver-ati mailing list at lists.x.org?
Comment 3 Alex Deucher 2012-03-26 05:51:50 UTC
Can you submit a patch?  Hardly anyone uses or maintains the UMS code any more and for those that do us it, it's working in most cases, so I'd don't think this is critical.
Comment 4 Sebastian D'Alessandro 2012-03-26 12:35:34 UTC
Created attachment 59084 [details] [review]
the patch

The function rhdAtomFirmwareInfoQuery has the same functionality as RADEONGetATOMClockInfo, we should try to eliminate duplicate code. RADEONGetATOMClockInfo did not have the bug, that is the reason no problems were detected before.
rhdAtomFirmwareInfoQuery is used in radeon_bios.c (function RADEONGetBIOSInfo) for no reason (the results are not used) and is also used to report the values in the log, so the only problem was to see pll_out_min as 0 even when the used value was correct.
If I find time I will try to fix all that or I will just wait until KMS replaces UMS for all of us.
I do not use git, If you want to apply the patch, please do it. If you don't, everything will continue working ok.
Comment 5 Adam Jackson 2018-06-12 19:06:53 UTC
Mass closure: This bug has been untouched for more than six years, and is not
obviously still valid. Please reopen this bug or file a new report if you continue to experience issues with current releases.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.