Bug 47928 - TpContact complains incorrectly about missing interfaces
Summary: TpContact complains incorrectly about missing interfaces
Status: RESOLVED DUPLICATE of bug 42737
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-26 17:00 UTC by Jonny Lamb
Modified: 2012-03-27 00:09 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Jonny Lamb 2012-03-26 17:00:30 UTC
TpContact has this:

  if (wanted & CONTACT_FEATURE_FLAG_PRESENCE)
    {
      boxed = tp_asv_get_boxed (asv,
          TP_TOKEN_CONNECTION_INTERFACE_SIMPLE_PRESENCE_PRESENCE,
          TP_STRUCT_TYPE_SIMPLE_PRESENCE);

      if (boxed == NULL)
        WARNING ("%s supposedly implements Contacts and SimplePresence, "
            "but omitted the mandatory "
            TP_TOKEN_CONNECTION_INTERFACE_SIMPLE_PRESENCE_PRESENCE
            " attribute",
            tp_proxy_get_object_path (connection));
      else
        contact_maybe_set_simple_presence (contact, boxed);
    }

So if the contact asks for the presence feature, TpContact is allowed to complain that the connection claims to support Contacts & SimplePresence but actually doesn't, even if the connection makes no such claim.

This is happening with rakia, and Empathy/Folks is trying to create TpContacts with a blanket set of features for all CMs, which I think is a reasonable thing to do.
Comment 1 Guillaume Desmottes 2012-03-27 00:09:30 UTC

*** This bug has been marked as a duplicate of bug 42737 ***


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.