Bug 47942 - remove tp_channel_manager_emit_new_channels
Summary: remove tp_channel_manager_emit_new_channels
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://cgit.freedesktop.org/~jonny/te...
Keywords: patch
Depends on: 47943
Blocks: tp-glib-1.0
  Show dependency treegraph
Reported: 2012-03-27 07:50 UTC by Jonny Lamb
Modified: 2012-05-11 03:01 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Description Jonny Lamb 2012-03-27 07:50:20 UTC
We should stop emitting channels together, it's just really complicated. Let's get rid of this function.

I'll open a spec bug about this kind of thing now too.
Comment 1 Jonny Lamb 2012-05-10 10:36:21 UTC
Here's a patch to deprecate it in master. Once merged I'll merge master into next and remove it there.

What do you think?
Comment 2 Xavier Claessens 2012-05-10 23:20:34 UTC
Comment 3 Jonny Lamb 2012-05-11 02:43:37 UTC
Great, thanks. I pushed this master, then merged master into next.

Here's the branch for next to remove the function.
Comment 4 Xavier Claessens 2012-05-11 02:53:20 UTC

Please fix the CMs too, I see gabble at least still use it
Comment 5 Jonny Lamb 2012-05-11 03:01:04 UTC
Merged, thanks.

gabble and salut still use this for announcing Text MUC channels & Tube & Tubes channels together.

I have a gabble branch to remove Tubes and fix this case so emit_new_channels isn't called. This should probably be the start of the gabble 'next' branch. I've yet to do the same thing in salut.

We will need to add some kind of workaround to gabble and salut master so it doesn't call the deprecated emit_new_channels.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.