While testing tubes using an XMPP server on localhost without a network connection, I found that the initiator neither falls back to in-band bytestreams upon discovering that there are no (non-loopback) local interfaces, not signals the recipient to say that the channel is dead. Thus began a journey through the hairier corners of SI and the bytestream code, culminating in a standards-incompliant fix for this edge case.
Reassuring diffstat; extensive commit messages. % git diff --stat 47999-handle-ibb-errors..48050-fallback src/bytestream-factory.c | 92 ++++++++---------------- src/bytestream-factory.h | 6 +- src/bytestream-socks5.c | 176 ++++++++++++++++++++++++++-------------------- src/ft-channel.c | 15 ++--- src/tube-dbus.c | 11 +--- src/tube-stream.c | 13 +--- 6 files changed, 145 insertions(+), 168 deletions(-)
hai?
Merged to master for 0.17.2. http://cgit.freedesktop.org/telepathy/telepathy-gabble/log/?id=3fe57e731b2518e22ba21efb4d16f50564363a2f
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.