Bug 48547 - stop using deprecated TpBaseChannelClass.interfaces, remove it from next
Summary: stop using deprecated TpBaseChannelClass.interfaces, remove it from next
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2012-04-11 04:26 UTC by Simon McVittie
Modified: 2012-04-26 10:08 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Don't use the deprecated TpBaseChannelClass.interfaces property (11.60 KB, patch)
2012-04-11 04:27 UTC, Simon McVittie
Details | Splinter Review
[next] TpBaseChannel: remove deprecated interfaces property (1.80 KB, patch)
2012-04-12 04:25 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2012-04-11 04:26:29 UTC
I tried to delete TpBaseChannelClass.interfaces, but quite a few places in tp-glib still use it.
Comment 1 Simon McVittie 2012-04-11 04:27:49 UTC
Created attachment 59799 [details] [review]
Don't use the deprecated TpBaseChannelClass.interfaces  property

---

After this has been merged to master, I'll do a patch for next to delete it entirely.
Comment 2 Jonny Lamb 2012-04-11 09:04:56 UTC
Comment on attachment 59799 [details] [review]
Don't use the deprecated TpBaseChannelClass.interfaces  property

Review of attachment 59799 [details] [review]:
-----------------------------------------------------------------

Yes.
Comment 3 Simon McVittie 2012-04-12 04:25:41 UTC
Created attachment 59849 [details] [review]
[next] TpBaseChannel: remove deprecated interfaces property
Comment 4 Simon McVittie 2012-04-12 04:26:07 UTC
Comment on attachment 59799 [details] [review]
Don't use the deprecated TpBaseChannelClass.interfaces  property

Committed for 0.19.0.
Comment 5 Jonny Lamb 2012-04-12 07:29:02 UTC
Comment on attachment 59849 [details] [review]
[next] TpBaseChannel: remove deprecated interfaces property

Review of attachment 59849 [details] [review]:
-----------------------------------------------------------------

Yes.
Comment 6 Simon McVittie 2012-04-26 10:08:45 UTC
Fixed in git for 1.0


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.