Bug 48627 - wayland-drm.c (in mesa) fails to compile (incompatible with wl_resource_destroy function signature)
Summary: wayland-drm.c (in mesa) fails to compile (incompatible with wl_resource_destr...
Status: VERIFIED FIXED
Alias: None
Product: Wayland
Classification: Unclassified
Component: wayland (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: medium major
Assignee: Wayland bug list
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-12 19:47 UTC by U. Artie Eoff
Modified: 2012-11-08 12:57 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description U. Artie Eoff 2012-04-12 19:47:38 UTC 
The current (as of this bug filing) mesa and wayland master HEAD's...

mesa (master) 6f03692775ed49035802d660516b7d7464c7a1ad
wayland (master) 18a770c80d59ef672e54688761bc8d0d9e660e12

...aren't compatible with one another. Mesa egl/wayland/wayland-drm/wayland-drm.c fails to compile due to a change in the wl_resource_destroy function signature (at wayland master commit 6802eaa68af90227b6614a84e7d3129e1f7a8303).

The following is the error output when compiling mesa with flags "--enable-gles2 --disable-gallium-egl --with-egl-platforms=x11,wayland,drm --enable-gbm --enable-shared-glapi":

...

gmake[2]: Entering directory `/home/uartie/wayland/src/mesa/src/egl'
gmake[3]: Entering directory `/home/uartie/wayland/src/mesa/src/egl/wayland'
Making all in wayland-drm
gmake[4]: Entering directory `/home/uartie/wayland/src/mesa/src/egl/wayland/wayland-drm'
  GEN    wayland-drm-protocol.c
  GEN    wayland-drm-client-protocol.h
  GEN    wayland-drm-server-protocol.h
gmake  all-am
gmake[5]: Entering directory `/home/uartie/wayland/src/mesa/src/egl/wayland/wayland-drm'
  CC     wayland-drm.lo
  CC     wayland-drm-protocol.lo
wayland-drm.c: In function 'buffer_destroy':
wayland-drm.c:70:2: error: too many arguments to function 'wl_resource_destroy'
/home/uartie/wayland/install/include/wayland-server.h:304:1: note: declared here
gmake[5]: *** [wayland-drm.lo] Error 1
gmake[5]: Leaving directory `/home/uartie/wayland/src/mesa/src/egl/wayland/wayland-drm'
gmake[4]: *** [all] Error 2
gmake[4]: Leaving directory `/home/uartie/wayland/src/mesa/src/egl/wayland/wayland-drm'
gmake[3]: *** [all-recursive] Error 1
gmake[3]: Leaving directory `/home/uartie/wayland/src/mesa/src/egl/wayland'
gmake[2]: *** [subdirs] Error 1
gmake[2]: Leaving directory `/home/uartie/wayland/src/mesa/src/egl'
make[1]: *** [subdirs] Error 1
make[1]: Leaving directory `/home/uartie/wayland/src/mesa/src'
make: *** [default] Error 1
Comment 1 Kristian Høgsberg 2012-04-12 19:52:56 UTC 
Fixed in mesa master now.  Mesa master now compiles with both wayland master and the tip of the 0.85 branch.
Comment 2 U. Artie Eoff 2012-04-12 20:05:41 UTC 
Are you sure?  It still fails for me with a fresh clone.

Push it?

U. Artie 

>-----Original Message-----
>From: wayland-bugs-
>bounces+ullysses.a.eoff=intel.com@lists.freedesktop.org [mailto:wayland-
>bugs-bounces+ullysses.a.eoff=intel.com@lists.freedesktop.org] On Behalf Of
>bugzilla-daemon@freedesktop.org
>Sent: Thursday, April 12, 2012 7:53 PM
>To: wayland-bugs@lists.freedesktop.org
>Subject: [Wayland-bugs] [Bug 48627] wayland-drm.c (in mesa) fails to compile
>(incompatible with wl_resource_destroy function signature)
>
>https://bugs.freedesktop.org/show_bug.cgi?id=48627
>
>Kristian Høgsberg <krh@bitplanet.net> changed:
>
>           What    |Removed                     |Added
>----------------------------------------------------------------------------
>             Status|NEW                         |RESOLVED
>         Resolution|                            |FIXED
>
>--- Comment #1 from Kristian Høgsberg <krh@bitplanet.net> 2012-04-12
>19:52:56 PDT ---
>Fixed in mesa master now.  Mesa master now compiles with both wayland
>master
>and the tip of the 0.85 branch.
>
>--
>Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
>------- You are receiving this mail because: -------
>You are the assignee for the bug.
>_______________________________________________
>Wayland-bugs mailing list
>Wayland-bugs@lists.freedesktop.org
>http://lists.freedesktop.org/mailman/listinfo/wayland-bugs
Comment 3 Kristian Høgsberg 2012-04-12 20:14:32 UTC 
Oops, did indeed forget to push.

thanks,
Kristian

On Thu, Apr 12, 2012 at 11:05 PM, Eoff, Ullysses A
<ullysses.a.eoff@intel.com> wrote:
> Are you sure?  It still fails for me with a fresh clone.
>
> Push it?
>
> U. Artie
>
>>-----Original Message-----
>>From: wayland-bugs-
>>bounces+ullysses.a.eoff=intel.com@lists.freedesktop.org [mailto:wayland-
>>bugs-bounces+ullysses.a.eoff=intel.com@lists.freedesktop.org] On Behalf Of
>>bugzilla-daemon@freedesktop.org
>>Sent: Thursday, April 12, 2012 7:53 PM
>>To: wayland-bugs@lists.freedesktop.org
>>Subject: [Wayland-bugs] [Bug 48627] wayland-drm.c (in mesa) fails to compile
>>(incompatible with wl_resource_destroy function signature)
>>
>>https://bugs.freedesktop.org/show_bug.cgi?id=48627
>>
>>Kristian Høgsberg <krh@bitplanet.net> changed:
>>
>>           What    |Removed                     |Added
>>----------------------------------------------------------------------------
>>             Status|NEW                         |RESOLVED
>>         Resolution|                            |FIXED
>>
>>--- Comment #1 from Kristian Høgsberg <krh@bitplanet.net> 2012-04-12
>>19:52:56 PDT ---
>>Fixed in mesa master now.  Mesa master now compiles with both wayland
>>master
>>and the tip of the 0.85 branch.
>>
>>--
>>Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
>>------- You are receiving this mail because: -------
>>You are the assignee for the bug.
>>_______________________________________________
>>Wayland-bugs mailing list
>>Wayland-bugs@lists.freedesktop.org
>>http://lists.freedesktop.org/mailman/listinfo/wayland-bugs
> _______________________________________________
> Wayland-bugs mailing list
> Wayland-bugs@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-bugs
Comment 4 U. Artie Eoff 2012-04-12 20:22:06 UTC 
Ah, thanks!  Indeed, mesa master 4f2eafe4dcea26d7275b121360c4f4e0b28455f5 fixed it :)

http://cgit.freedesktop.org/mesa/mesa/commit/?id=4f2eafe4dcea26d7275b121360c4f4e0b28455f5

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.