Bug 4885 - make check with xcb backend is broken
Summary: make check with xcb backend is broken
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: xcb backend (show other bugs)
Version: 1.1.1
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Carl Worth
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-25 16:01 UTC by Bertram Felgenhauer
Modified: 2006-04-27 09:43 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
proposed patch (957 bytes, patch)
2005-10-25 16:04 UTC, Bertram Felgenhauer
Details | Splinter Review

Description Bertram Felgenhauer 2005-10-25 16:01:13 UTC
'make check' with an XCB-enabled cairo hangs in every test.
The reason is that the interface for creating surfaces was changed to support
argb32 and rgb24 outputs; create_xcb_surface did not follow that change.
Comment 1 Bertram Felgenhauer 2005-10-25 16:04:03 UTC
Created attachment 3633 [details] [review]
proposed patch

Changelog:

2005-10-26  Bertram Felgenhauer  <int-e@gmx.de>

	* test/cairo-test.c (create_xcb_surface): change interface to follow
	the recent argb32/rgb24 testing support. (Bug 4885)
Comment 2 Carl Worth 2005-10-25 16:06:51 UTC
Thanks for the catch. Please commit.
Comment 3 Bertram Felgenhauer 2006-04-28 02:43:55 UTC
The patch (or some equivalent patch) was applied. Closing bug.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.