When checking for GConf in configure.ac, it's wrong to check for ORBit. In the old days when GConf used ORBit this would have been pulled in anyway, and GCOnf doesn't use ORBit anymore.
Created attachment 60248 [details] Patch Attachd a patch. This is untested, I don't know if this spurious ORBit dependency is actually required by some unrelated code.
Created attachment 60274 [details] More removal Also don't check for an ancient version of ORBit (released 2003) when loading GConf (which since 2011 doesn't use ORBit).
Comment on attachment 60274 [details] More removal Review of attachment 60274 [details]: ----------------------------------------------------------------- ::: shell/source/backends/gconfbe/gconfbackend.cxx @@ +164,4 @@ > rtl::OUString( > RTL_CONSTASCII_USTRINGPARAM("system.desktop-environment"))) >>= > desktop; > + enabled_ = desktop == "GNOME" missing ';' :)
Created attachment 60275 [details] Revised patch Dude, are you reviewing in the pub?
I'd remove the check from configure too: --- a/configure.in +++ b/configure.in @@ -8472,7 +8472,7 @@ AC_MSG_CHECKING([whether to enable GConf support]) if test "$_os" != "WINNT" -a "$_os" != "Darwin" -a "$enable_gconf" = "yes"; then ENABLE_GCONF="TRUE" AC_MSG_RESULT([yes]) - PKG_CHECK_MODULES( GCONF, gconf-2.0 ORBit-2.0 ) + PKG_CHECK_MODULES( GCONF, gconf-2.0 ) else AC_MSG_RESULT([no]) fi Otherwise it compiles nicely in shell/ and looks much better - thanks ! :-) Please can you post the patch to the list with a Subject: beginning [PATCH] - and we also need an explicit: MPL/LGPLv3+ license statement - preferably for all your contributions cf. https://wiki.documentfoundation.org/Development/Developers#Companies Thanks ! :-)
Created attachment 60304 [details] Final patch Revised patch, just the previous ones squashed.
this got pushed already I believe :-) thanks !