RFE: We need a workaround for bug 467 ("Xfree86's smart scheduler breaks Xprt") for now...
Created attachment 206 [details] [review] Patch for 2004-04-17-trunk
Patch checked-in... Checking in xc/config/cf/xprint_site.def; /cvs/xorg/xc/config/cf/Attic/xprint_site.def,v <-- xprint_site.def new revision: 1.1.2.7; previous revision: 1.1.2.6 done Mailing xorg-commit-diffs@freedesktop.org... Generating notification message... Generating notification message... done. Checking in xc/programs/Xserver/dix/dispatch.c; /cvs/xorg/xc/programs/Xserver/dix/dispatch.c,v <-- dispatch.c new revision: 1.1.4.4.2.3.6.1; previous revision: 1.1.4.4.2.3 done Mailing the commit message to xorg-commit@pdx.freedesktop.org... Mailing xorg-commit-diffs@freedesktop.org... Generating notification message... Generating notification message... done. ... marking bug as FIXED.
Reopening... the patch can't work since the |XPRINT| define isn't actually set... ;-(
Created attachment 207 [details] [review] Prototype patch for 2004-04-17-trunk The patch adds a new function |ddxInitGlobals()|. The original issue is now "fixed" (or better: worked around) but the patch still needs work since all other drivers now need dummy implementations for |ddxInitGlobals()|.
Alan/Kaleb: Is it OK that I'll add a new function |ddxInitGlobals()| to all other drivers (e.g. this is something which affects everyone, not only Xprint... this may be an issue when the changes are merged into TRUNK...) ?
Created attachment 216 [details] [review] New patch for 2004-04-20-trunk
Comment on attachment 216 [details] [review] New patch for 2004-04-20-trunk THe new patch adds the new |ddxInitGlobals()| function to add drivers who need it. Additionally I added two safeguards to the Xprint init code to ensure that we won't see this bug ever again in a running Xprt server (Xprt now exists with an error if the smart schuduler somehow manages to become active).
Patch checked-in... Checking in xc/programs/Xserver/Xprint/Init.c; /cvs/xorg/xc/programs/Xserver/Xprint/Init.c,v <-- Init.c new revision: 1.1.4.2.6.1.6.2; previous revision: 1.1.4.2.6.1.6.1 done Checking in xc/programs/Xserver/Xprint/ddxInit.c; /cvs/xorg/xc/programs/Xserver/Xprint/ddxInit.c,v <-- ddxInit.c new revision: 1.1.4.2.6.1.6.2; previous revision: 1.1.4.2.6.1.6.1 done Mailing xorg-commit-diffs@freedesktop.org... Generating notification message... Generating notification message... done. Checking in xc/programs/Xserver/dix/dispatch.c; /cvs/xorg/xc/programs/Xserver/dix/dispatch.c,v <-- dispatch.c new revision: 1.1.4.4.2.3.6.2; previous revision: 1.1.4.4.2.3.6.1 done Checking in xc/programs/Xserver/dix/main.c; /cvs/xorg/xc/programs/Xserver/dix/main.c,v <-- main.c new revision: 1.1.4.5.2.4.6.1; previous revision: 1.1.4.5.2.4 done Mailing xorg-commit-diffs@freedesktop.org... Generating notification message... Generating notification message... done. Checking in xc/programs/Xserver/hw/darwin/darwin.c; /cvs/xorg/xc/programs/Xserver/hw/darwin/darwin.c,v <-- darwin.c new revision: 1.1.4.2.4.1.6.3; previous revision: 1.1.4.2.4.1.6.2 done Mailing xorg-commit-diffs@freedesktop.org... Generating notification message... Generating notification message... done. Checking in xc/programs/Xserver/hw/sun/sunIo.c; /cvs/xorg/xc/programs/Xserver/hw/sun/sunIo.c,v <-- sunIo.c new revision: 1.1.4.2.6.1.6.1; previous revision: 1.1.4.2.6.1 done Mailing xorg-commit-diffs@freedesktop.org... Generating notification message... Generating notification message... done. Checking in xc/programs/Xserver/hw/sunLynx/sunLyIo.c; /cvs/xorg/xc/programs/Xserver/hw/sunLynx/sunLyIo.c,v <-- sunLyIo.c new revision: 1.1.4.2.6.1.6.1; previous revision: 1.1.4.2.6.1 done Mailing xorg-commit-diffs@freedesktop.org... Generating notification message... Generating notification message... done. Checking in xc/programs/Xserver/hw/vfb/InitOutput.c; /cvs/xorg/xc/programs/Xserver/hw/vfb/InitOutput.c,v <-- InitOutput.c new revision: 1.1.4.2.6.1.6.1; previous revision: 1.1.4.2.6.1 done Mailing xorg-commit-diffs@freedesktop.org... Generating notification message... Generating notification message... done. Checking in xc/programs/Xserver/hw/xfree86/common/xf86Init.c; /cvs/xorg/xc/programs/Xserver/hw/xfree86/common/xf86Init.c,v <-- xf86Init.c new revision: 1.1.4.5.2.1.4.2; previous revision: 1.1.4.5.2.1.4.1 done Mailing xorg-commit-diffs@freedesktop.org... Generating notification message... Generating notification message... done. Checking in xc/programs/Xserver/hw/xnest/Args.c; /cvs/xorg/xc/programs/Xserver/hw/xnest/Args.c,v <-- Args.c new revision: 1.1.4.1.6.1.6.1; previous revision: 1.1.4.1.6.1 done Mailing xorg-commit-diffs@freedesktop.org... Generating notification message... Generating notification message... done. Checking in xc/programs/Xserver/hw/xwin/InitOutput.c; /cvs/xorg/xc/programs/Xserver/hw/xwin/InitOutput.c,v <-- InitOutput.c new revision: 1.1.4.1.6.1.6.2; previous revision: 1.1.4.1.6.1.6.1 done Mailing xorg-commit-diffs@freedesktop.org... Generating notification message... Generating notification message... done. Checking in xc/programs/Xserver/include/os.h; /cvs/xorg/xc/programs/Xserver/include/os.h,v <-- os.h new revision: 1.1.4.3.6.2.2.1; previous revision: 1.1.4.3.6.2 done Mailing xorg-commit-diffs@freedesktop.org... Generating notification message... Generating notification message... done. Checking in xc/programs/Xserver/os/utils.c; /cvs/xorg/xc/programs/Xserver/os/utils.c,v <-- utils.c new revision: 1.1.4.6.2.4.6.3; previous revision: 1.1.4.6.2.4.6.2 done Mailing the commit message to xorg-commit@pdx.freedesktop.org... Mailing xorg-commit-diffs@freedesktop.org... Generating notification message... Generating notification message... done. ... marking bug as FIXED.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.