AFAIK it's not safe to use a memblockq from multiple threads without synchronization. module-echo-cancel does that.
Actually, most of the mistakes that I thought I saw were only mistakes/unclarities in the comments. This bug is still valid, though, because sink_input_update_max_rewind_cb() calls pa_memblockq_set_maxrewind(u->sink_memblockq, nbytes);
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/157.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.